Issue 119753010: Revert "Revert of https://codereview.chromium.org/110593003/"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119753010: Revert "Revert of https://codereview.chromium.org/110593003/" (Closed)

Created:
6 years, 11 months ago by reed1

Modified:
6 years, 11 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert "Revert of https://codereview.chromium.org/110593003/" This reverts commit c7abb25b25ba8b97948371d2bf0a2e3e78468f73. and fixes the ashmem break BUG= Committed: https://code.google.com/p/skia/source/detail?r=12887

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+216 lines, -128 lines)			Patch
M	include/core/SkBitmapDevice.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/core/SkMallocPixelRef.h	View	2 chunks	+4 lines, -6 lines	0 comments	Download
M	include/core/SkPixelRef.h	View	4 chunks	+55 lines, -18 lines	0 comments	Download
M	include/gpu/SkGrPixelRef.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	include/images/SkImageRef.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+17 lines, -18 lines	0 comments	Download
M	src/core/SkMallocPixelRef.cpp	View	4 chunks	+9 lines, -7 lines	0 comments	Download
M	src/core/SkPixelRef.cpp	View	6 chunks	+55 lines, -24 lines	0 comments	Download
M	src/core/SkScaledImageCache.cpp	View	4 chunks	+12 lines, -11 lines	0 comments	Download
M	src/gpu/SkGrPixelRef.cpp	View	1 chunk	+10 lines, -6 lines	0 comments	Download
M	src/images/SkImageRef.cpp	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	src/images/SkImageRef_ashmem.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/images/SkImageRef_ashmem.cpp	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/lazy/SkCachingPixelRef.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lazy/SkCachingPixelRef.cpp	View	5 chunks	+11 lines, -8 lines	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/lazy/SkDiscardablePixelRef.cpp	View	2 chunks	+15 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)

reed1

6 years, 11 months ago (2014-01-03 17:59:10 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r12887 (presubmit successful).