Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 11975049: Allowing inlining of static getters and methods in a different library. Also report an error if a g… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/resolution/members.dart (revision 17215)
+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart (working copy)
@@ -3225,6 +3225,12 @@
Diagnostic.ERROR);
}
}
+ if (element.isGetter() && (requiredParameterCount != 0
+ || visitor.optionalParameterCount != 0)) {
+ compiler.reportMessage(compiler.spanFromSpannable(formalParameters),
+ MessageKind.EXTRA_FORMALS.error([]),
+ Diagnostic.ERROR);
+ }
return new FunctionSignatureX(parameters,
visitor.optionalParameters,
requiredParameterCount,
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698