Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: content/browser/renderer_host/media/audio_sync_reader.cc

Issue 11975031: Track UMA stats for when the renderer side audio device wasn't ready. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup! Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/media/audio_sync_reader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/audio_sync_reader.cc
diff --git a/content/browser/renderer_host/media/audio_sync_reader.cc b/content/browser/renderer_host/media/audio_sync_reader.cc
index 0730ec20f4022b40c9fa7df46f4d28e18324df5c..620ba546810f306a58fdf7a8418fcdc284d8c94c 100644
--- a/content/browser/renderer_host/media/audio_sync_reader.cc
+++ b/content/browser/renderer_host/media/audio_sync_reader.cc
@@ -6,6 +6,7 @@
#include <algorithm>
+#include "base/metrics/histogram.h"
#include "base/process_util.h"
#include "base/shared_memory.h"
#include "media/audio/audio_buffers_state.h"
@@ -20,7 +21,9 @@ AudioSyncReader::AudioSyncReader(base::SharedMemory* shared_memory,
const media::AudioParameters& params,
int input_channels)
: shared_memory_(shared_memory),
- input_channels_(input_channels) {
+ input_channels_(input_channels),
+ renderer_callback_count_(0),
+ renderer_missed_callback_count_(0) {
packet_size_ = media::PacketSizeInBytes(shared_memory_->created_size());
int input_memory_size = 0;
int output_memory_size = AudioBus::CalculateMemorySize(params);
@@ -37,6 +40,15 @@ AudioSyncReader::AudioSyncReader(base::SharedMemory* shared_memory,
}
AudioSyncReader::~AudioSyncReader() {
+ if (!renderer_callback_count_)
+ return;
+
+ // Recording the percentage of deadline misses gives us a rough overview of
+ // how many users might be running into audio glitches.
+ int percentage_missed =
+ 100.0 * renderer_missed_callback_count_ / renderer_callback_count_;
+ UMA_HISTOGRAM_PERCENTAGE(
+ "Media.AudioRendererMissedDeadline", percentage_missed);
}
bool AudioSyncReader::DataReady() {
@@ -57,6 +69,10 @@ void AudioSyncReader::UpdatePendingBytes(uint32 bytes) {
}
int AudioSyncReader::Read(AudioBus* source, AudioBus* dest) {
+ ++renderer_callback_count_;
+ if (!DataReady())
+ ++renderer_missed_callback_count_;
+
// Copy optional synchronized live audio input for consumption by renderer
// process.
if (source && input_bus_.get()) {
« no previous file with comments | « content/browser/renderer_host/media/audio_sync_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698