Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 11975022: [Telemetry] Clean separation between tab (public) and tab_backend (Chrome); second attempt. (Closed)

Created:
7 years, 11 months ago by dtu
Modified:
7 years, 11 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Clean separation between tab (public) and tab_backend (Chrome); second attempt. First attempt here: https://chromiumcodereview.appspot.com/11819018/ BUG=None. TEST=./run_tests in telemetry and perf for both release and system browsers. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -203 lines) Patch
M tools/telemetry/telemetry/browser_backend.py View 5 chunks +10 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/inspector_console.py View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/inspector_console_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/inspector_page.py View 4 chunks +8 lines, -67 lines 0 comments Download
M tools/telemetry/telemetry/inspector_page_unittest.py View 1 chunk +0 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/inspector_runtime.py View 2 chunks +4 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/inspector_timeline.py View 4 chunks +9 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/tab.py View 3 chunks +99 lines, -89 lines 0 comments Download
A tools/telemetry/telemetry/tab_backend.py View 1 chunk +298 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/tab_unittest.py View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
7 years, 11 months ago (2013-01-16 22:57:06 UTC) #1
nduca
lgtm but the __runtime etc stuff on the backedn is funky to me. I hope ...
7 years, 11 months ago (2013-01-16 23:00:32 UTC) #2
dtu
On 2013/01/16 23:00:32, nduca wrote: > lgtm but the __runtime etc stuff on the backedn ...
7 years, 11 months ago (2013-01-16 23:10:39 UTC) #3
dtu
7 years, 11 months ago (2013-01-16 23:13:45 UTC) #4
On 2013/01/16 23:10:39, Dave Tu wrote:
> On 2013/01/16 23:00:32, nduca wrote:
> > lgtm but the __runtime etc stuff on the backedn is funky to me. I hope it
goes
> > away
> 
> Mostly they're there to ensure you're Connected for all those calls. I think
> that it's possible to explicitly Connect and Disconnect in SyncRequest() and
> DispatchNotifications(). Actually now that I think about it, I wonder why we
> didn't do that way from the start. Then you don't need these, or the weakrefs
in
> TabController, or a public API Disconnect() call.

I guess that requires that connecting and disconnecting are cheap, but you said
most of the overhead is in maintaining the inspector instrumentation, right? Not
in the connection.

Powered by Google App Engine
This is Rietveld 408576698