chromeos/dbus/shill_service_client.cc - Issue 11975015: This adds a private extension API to use for simple networking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_service_client.cc

Issue 11975015: This adds a private extension API to use for simple networking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed self review nits Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_service_client.cc

diff --git a/chromeos/dbus/shill_service_client.cc b/chromeos/dbus/shill_service_client.cc

index 16d7767853d78e143b1e170df453e0cc029bf287..8e0ede00f565ea2ecb7d795702c48a3891816029 100644

--- a/chromeos/dbus/shill_service_client.cc

+++ b/chromeos/dbus/shill_service_client.cc

@@ -312,6 +312,11 @@ class ShillServiceClientStubImpl : public ShillServiceClient,

virtual void Connect(const dbus::ObjectPath& service_path,

const base::Closure& callback,

const ErrorCallback& error_callback) OVERRIDE {

+ base::Value* service;

+ if (!stub_services_.Get(service_path.value(), &service)) {

+ error_callback.Run("Error.InvalidService", "Invalid Service");

+ return;

+ }

// Set Associating

base::StringValue associating_value(flimflam::kStateAssociation);

SetServiceProperty(service_path.value(),