This adds a private extension API to use for simple networking

chrome/test/data/extensions/api_test/networking/test.js

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var EXTENSION_ID = 'epcifkihnkjgphfkloaaleeakhpmgdmn';

[not at google - send to devlin, 2013/01/23 22:37:52]

There's actually a property chrome.runtime.id that contains the extension ID
automatically.

[Greg Spencer (Chromium), 2013/02/01 23:35:55]

Done.

+var FILE_CONTENTS = 'hello from test extension.';
+
+chrome.test.runTests([
+  function getVisibleNetworks() {
+    chrome.networkingPrivate.getVisibleNetworks(
+        "All",
+        function(result) {

[not at google - send to devlin, 2013/01/23 22:37:52]

For asynchronous callbacks you need to wrap them in callbackPass() to keep the
test running - otherwise the next test will run, which might interfere with
things - and the test might think that it's finished when in fact it hasn't.

You also don't need the chrome.test.succeed() nor the chrome.runtime.lastError
check in that case, they will happen automatically.

[Greg Spencer (Chromium), 2013/02/01 23:35:55]

Done.

+          chrome.test.assertTrue(!!result);
+          chrome.test.assertTrue(!chrome.runtime.lastError);
+          console.log("Visible Networks: " + JSON.stringify(result));

[not at google - send to devlin, 2013/01/23 22:37:52]

Remove logging before submitting

[Greg Spencer (Chromium), 2013/02/01 23:35:55]

Done.

+          chrome.test.assertEq(4, result.length);

[not at google - send to devlin, 2013/01/23 22:37:52]

assertEq works with objects, so

chrome.test.assertEq([
  { "Name": "eth0" },
  { "Name": "wifi1" },
  ...
  ], result);

would be easier to read.

Incidentally, usually object keys are camelCase, so I'd expect these to be
"name", "connectionState", "type", etc.

These comments apply to all the other tests too.

[Greg Spencer (Chromium), 2013/02/01 23:35:55]

Done.  The only bad thing about doing it this way is that if something fails you
don't immediately see in the results what field was missing/wrong, and have to
diff the objects visually, but the code is more readable.
These values are using ONC naming conventions, which is why it's not camel case:
it wouldn't be valid ONC then.

[not at google - send to devlin, 2013/02/02 00:11:32]

If this becomes a problem it's something we can fix within assertEq.

+          chrome.test.assertEq("eth0", result[0].Name);
+          chrome.test.assertEq("wifi1", result[1].Name);
+          chrome.test.assertEq("wifi2_PSK", result[2].Name);
+          chrome.test.assertEq("cellular1", result[3].Name);
+          chrome.test.assertEq("stub_ethernet", result[0].GUID);
+          chrome.test.assertEq("stub_wifi1", result[1].GUID);
+          chrome.test.assertEq("stub_wifi2", result[2].GUID);
+          chrome.test.assertEq("stub_cellular1", result[3].GUID);
+          chrome.test.assertEq("Connected", result[0].ConnectionState);
+          chrome.test.assertEq("Connected", result[1].ConnectionState);
+          chrome.test.assertEq("NotConnected", result[2].ConnectionState);
+          chrome.test.assertEq("NotConnected", result[3].ConnectionState);
+          chrome.test.assertEq("Ethernet", result[0].Type);
+          chrome.test.assertEq("WiFi", result[1].Type);
+          chrome.test.assertEq("WiFi", result[2].Type);
+          chrome.test.assertEq("Cellular", result[3].Type);
+          chrome.test.succeed();
+      });
+  },
+  function getVisibleNetworksWifi() {
+    chrome.networkingPrivate.getVisibleNetworks(
+      "WiFi",
+      function(result) {
+        chrome.test.assertTrue(!!result);
+        chrome.test.assertTrue(!chrome.runtime.lastError);
+        console.log("Visible Networks WiFi: " + JSON.stringify(result));
+        chrome.test.assertEq(2, result.length);
+        chrome.test.assertEq("wifi1", result[0].Name);
+        chrome.test.assertEq("wifi2_PSK", result[1].Name);
+        chrome.test.assertEq("stub_wifi1", result[0].GUID);
+        chrome.test.assertEq("stub_wifi2", result[1].GUID);
+        chrome.test.assertEq("Connected", result[0].ConnectionState);
+        chrome.test.assertEq("NotConnected", result[1].ConnectionState);
+        chrome.test.assertEq("WiFi", result[0].Type);
+        chrome.test.assertEq("WiFi", result[1].Type);
+        chrome.test.succeed();
+      });
+  },
+  function getProperties() {
+    chrome.networkingPrivate.getProperties(
+        "stub_wifi2",
+        function(result) {
+          chrome.test.assertTrue(!!result);
+          chrome.test.assertTrue(!chrome.runtime.lastError);
+          console.log("GetProperties: " + JSON.stringify(result));
+          chrome.test.assertEq("wifi2_PSK", result.Name);
+          chrome.test.assertEq("NotConnected", result.ConnectionState);
+          chrome.test.assertEq("WiFi", result.Type);
+          chrome.test.succeed();
+      });
+  },
+  function requestConnect() {
+    chrome.networkingPrivate.requestConnect(
+        "stub_wifi2",
+        function() {
+          chrome.test.assertTrue(!chrome.runtime.lastError);
+          chrome.test.succeed();
+      });
+  },
+  function requestDisconnect() {
+    chrome.networkingPrivate.requestDisconnect(
+        "stub_wifi2",
+        function() {
+          chrome.test.assertTrue(!chrome.runtime.lastError);
+          chrome.test.succeed();
+      });
+  },
+  function requestConnectNonexistent() {
+    chrome.networkingPrivate.requestConnect(
+        "nonexistent_path",
+        function() {
+          // Make sure we get an error when we try to connect to a nonexistent
+          // network.
+          chrome.test.assertTrue(!!chrome.runtime.lastError);
+          chrome.test.assertTrue(!!chrome.runtime.lastError.message);
+          chrome.test.assertEq("Error.InvalidService",
+                               chrome.runtime.lastError.message);

[not at google - send to devlin, 2013/01/23 22:37:52]

For these, use callbackFail - it's the same as callbackPass but accepts a second
argument, the expected failure message.

[Greg Spencer (Chromium), 2013/02/01 23:35:55]

Done.

+          chrome.test.succeed();
+      });
+  }
+]);