chrome/test/data/extensions/api_test/networking/background.js - Issue 11975015: This adds a private extension API to use for simple networking - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(360)

My Issues | Starred Open | Closed | All

Side by Side Diff: chrome/test/data/extensions/api_test/networking/background.js

Issue 11975015: This adds a private extension API to use for simple networking (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Upload after merge Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/api/networking_private.json ('K') | « chrome/common/extensions_api_resources.grd ('k') | chrome/test/data/extensions/api_test/networking/manifest.json » ('j') | chrome/test/data/extensions/api_test/networking/test.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 document.write("g o o g l e");	5 chrome.tabs.create({

	6 url: "test.html"

	7 });
	not at google - send to devlin 2013/01/23 22:37:52 Is there a reason the test can't be entirely run f Is there a reason the test can't be entirely run from the background page? Greg Spencer (Chromium) 2013/01/31 16:40:36 No. Done. Show quoted text On 2013/01/23 22:37:52, kalman wrote: > Is there a reason the test can't be entirely run from the background page? No. Done. Greg Spencer (Chromium) 2013/01/31 16:43:01 [Whoops, forgot to change this comment before publ Show quoted text On 2013/01/31 16:40:36, Greg Spencer (Chromium) wrote: > On 2013/01/23 22:37:52, kalman wrote: > > Is there a reason the test can't be entirely run from the background page? > > No. Done. [Whoops, forgot to change this comment before publishing.] Actually, I tried this, and the browser tests just hangs, so I guess that's not going to work. not at google - send to devlin 2013/02/01 19:09:42 I think it will work, it's a matter of making the Show quoted text On 2013/01/31 16:43:01, Greg Spencer (Chromium) wrote: > On 2013/01/31 16:40:36, Greg Spencer (Chromium) wrote: > > On 2013/01/23 22:37:52, kalman wrote: > > > Is there a reason the test can't be entirely run from the background page? > > > > No. Done. > > [Whoops, forgot to change this comment before publishing.] > > Actually, I tried this, and the browser tests just hangs, so I guess that's not > going to work. I think it will work, it's a matter of making the test pass... either that or this API really doesn't work from background pages, and that would be a problem. Greg Spencer (Chromium) 2013/02/01 23:35:55 Huh, well I tried it again (before making your oth Show quoted text On 2013/02/01 19:09:42, kalman wrote: > On 2013/01/31 16:43:01, Greg Spencer (Chromium) wrote: > > On 2013/01/31 16:40:36, Greg Spencer (Chromium) wrote: > > > On 2013/01/23 22:37:52, kalman wrote: > > > > Is there a reason the test can't be entirely run from the background page? > > > > > > No. Done. > > > > [Whoops, forgot to change this comment before publishing.] > > > > Actually, I tried this, and the browser tests just hangs, so I guess that's > not > > going to work. > > I think it will work, it's a matter of making the test pass... either that or > this API really doesn't work from background pages, and that would be a problem. Huh, well I tried it again (before making your other changes in test.js), and it worked just fine this time. Not sure what I did incorrectly last time. I ran it several times to make sure it wasn't flaky (which it shouldn't be: it's using a stub).
OLD	NEW

« chrome/common/extensions/api/networking_private.json ('K') | « chrome/common/extensions_api_resources.grd ('k') | chrome/test/data/extensions/api_test/networking/manifest.json » ('j') | chrome/test/data/extensions/api_test/networking/test.js » ('J')

Powered by Google App Engine

This is Rietveld 408576698