Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 11975006: Merge 139419 (Closed)

Created:
7 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139419 > Connect UserGestureIndicator for mousedown and mouseup events > https://bugs.webkit.org/show_bug.cgi?id=105138 > > Reviewed by Adam Barth. > > Source/WebCore: > > Ports that consume user gestures to prevent certain types of pop-ups > need to be able to connect mousedown and mouseup events, otherwise, a > single mouse click will allow for opening multiple pop-ups. > > Note that a mousedown is not always followed by a mouseup and vice > versa, e.g. when the mousedown results in a context menu being shown, or > something is dragged into the page. > > Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html > > * page/EventHandler.cpp: > (WebCore::EventHandler::clear): > (WebCore::EventHandler::handleMousePressEvent): > (WebCore::EventHandler::handleMouseReleaseEvent): > * page/EventHandler.h: > > LayoutTests: > > * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added. > * platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added. > TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A + LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/page/EventHandler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/page/EventHandler.cpp View 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
7 years, 9 months ago (2013-01-16 08:20:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698