chrome/test/chromedriver/chrome_impl.cc - Issue 11975003: [ChromeDriver] Add support for attaching multiple DevToolsEventListeners to a DevToolsClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome_impl.cc

Issue 11975003: [ChromeDriver] Add support for attaching multiple DevToolsEventListeners to a DevToolsClient. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/chrome_impl.cc

diff --git a/chrome/test/chromedriver/chrome_impl.cc b/chrome/test/chromedriver/chrome_impl.cc

index adbfab9acd04325df27646134fd2bff2f0540208..2e62d3a0434069e8fadfaaa0e0f40e1a19a2e55d 100644

--- a/chrome/test/chromedriver/chrome_impl.cc

+++ b/chrome/test/chromedriver/chrome_impl.cc

@@ -81,7 +81,8 @@ Status ChromeImpl::Init() {

if (debugger_urls.empty())

return Status(kUnknownError, "unable to discover open pages");

client_.reset(new DevToolsClientImpl(

- socket_factory_, debugger_urls.front(), dom_tracker_.get()));

+ socket_factory_, debugger_urls.front()));

+ client_->AddListener(dom_tracker_.get());

// Perform necessary configuration of the DevTools client.

// Fetch the root document node so that Inspector will push DOM node

« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome_impl_unittest.cc » ('j') | chrome/test/chromedriver/devtools_client_impl.cc » ('J')