SP: add a scope recorder for painting inline continuation outlines.

SP: add a scope recorder for painting inline continuation outlines.


BUG=501709
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197486

[chrishtr, 2015-06-18 20:10:10]

chrishtr@chromium.org changed reviewers:
+ leviw@chromium.org

[leviw_travelin_and_unemployed, 2015-06-18 20:40:16]

LGTM

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
File LayoutTests/paint/inline/self-painting-continuation-outline-expected.html
(right):

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
LayoutTests/paint/inline/self-painting-continuation-outline-expected.html:6: 
Nit: Extra line.

Can we also make the outline apply to just the outer span?

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
File LayoutTests/paint/inline/self-painting-continuation-outline.html (right):

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
LayoutTests/paint/inline/self-painting-continuation-outline.html:3: * {
Can we make this only apply to the target as well?

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
LayoutTests/paint/inline/self-painting-continuation-outline.html:11:
<div>Content 1</div>
"Test passes if no assert with Slimming Paint"?

[chrishtr, 2015-06-18 21:00:42]

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
File LayoutTests/paint/inline/self-painting-continuation-outline-expected.html
(right):

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
LayoutTests/paint/inline/self-painting-continuation-outline-expected.html:6: 
On 2015/06/18 at 20:40:16, leviw wrote:
> Nit: Extra line.
> 
> Can we also make the outline apply to just the outer span?

Done.

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
File LayoutTests/paint/inline/self-painting-continuation-outline.html (right):

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
LayoutTests/paint/inline/self-painting-continuation-outline.html:3: * {
On 2015/06/18 at 20:40:16, leviw wrote:
> Can we make this only apply to the target as well?

Done.

https://codereview.chromium.org/1197443003/diff/20001/LayoutTests/paint/inlin...
LayoutTests/paint/inline/self-painting-continuation-outline.html:11:
<div>Content 1</div>
On 2015/06/18 at 20:40:16, leviw wrote:
> "Test passes if no assert with Slimming Paint"?

It's implied that tests don't crash. This test tests two things: not crashing
and painting as expected.

[chrishtr, 2015-06-19 04:17:37]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-06-19 04:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from leviw@chromium.org
Link to the patchset: https://codereview.chromium.org/1197443003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-06-19 04:17:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197443003/80001

[commit-bot: I haz the power, 2015-06-19 06:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 06:23:56]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59693)

[chrishtr, 2015-06-19 15:14:01]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2015-06-19 15:14:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197443003/80001

[commit-bot: I haz the power, 2015-06-19 16:58:30]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197486