Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/mac.py

Issue 1197433002: Fix position of Mac retina in lists ordered according to fallback chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 20 matching lines...) Expand all
31 import logging 31 import logging
32 import signal 32 import signal
33 33
34 from webkitpy.layout_tests.port import base 34 from webkitpy.layout_tests.port import base
35 35
36 36
37 _log = logging.getLogger(__name__) 37 _log = logging.getLogger(__name__)
38 38
39 39
40 class MacPort(base.Port): 40 class MacPort(base.Port):
41 SUPPORTED_VERSIONS = ('snowleopard', 'lion', 'retina', 'mountainlion', 'mave ricks', 'yosemite') 41 SUPPORTED_VERSIONS = ('snowleopard', 'lion', 'mountainlion', 'retina', 'mave ricks', 'yosemite')
42 port_name = 'mac' 42 port_name = 'mac'
43 43
44 # FIXME: We treat Retina (High-DPI) devices as if they are running 44 # FIXME: We treat Retina (High-DPI) devices as if they are running
45 # a different operating system version. This is lame and should be fixed. 45 # a different operating system version. This is lame and should be fixed.
46 # Note that the retina versions fallback to the non-retina versions and so n o 46 # Note that the retina versions fallback to the non-retina versions and so n o
47 # baselines are shared between retina versions; this keeps the fallback grap h as a tree 47 # baselines are shared between retina versions; this keeps the fallback grap h as a tree
48 # and maximizes the number of baselines we can share that way. 48 # and maximizes the number of baselines we can share that way.
49 # We also currently only support Retina on 10.9. 49 # We also currently only support Retina on 10.9.
50 50
51 FALLBACK_PATHS = {} 51 FALLBACK_PATHS = {}
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 def _path_to_driver(self, configuration=None): 111 def _path_to_driver(self, configuration=None):
112 # FIXME: make |configuration| happy with case-sensitive file systems. 112 # FIXME: make |configuration| happy with case-sensitive file systems.
113 return self._build_path_with_configuration(configuration, self.driver_na me() + '.app', 'Contents', 'MacOS', self.driver_name()) 113 return self._build_path_with_configuration(configuration, self.driver_na me() + '.app', 'Contents', 'MacOS', self.driver_name())
114 114
115 def _path_to_helper(self): 115 def _path_to_helper(self):
116 binary_name = 'layout_test_helper' 116 binary_name = 'layout_test_helper'
117 return self._build_path(binary_name) 117 return self._build_path(binary_name)
118 118
119 def _path_to_wdiff(self): 119 def _path_to_wdiff(self):
120 return 'wdiff' 120 return 'wdiff'
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/base.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698