Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 1197433002: Fix position of Mac retina in lists ordered according to fallback chain. (Closed)

Created:
4 years, 10 months ago by joelo
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, jsbell, ojan
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Fix position of Mac retina in lists ordered according to fallback chain. Retina now comes right before Mavericks since it now falls back to 10.9. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197402

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/mac.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
joelo
nit fix from issue 1173403006
4 years, 10 months ago (2015-06-18 18:26:57 UTC) #2
ojan
I'll leave the actual review for Dirk, but on a side note, once we have ...
4 years, 10 months ago (2015-06-18 18:38:30 UTC) #3
joelo
On 2015/06/18 18:38:30, ojan wrote: > I'll leave the actual review for Dirk, but on ...
4 years, 10 months ago (2015-06-18 18:57:08 UTC) #4
Dirk Pranke
lgtm
4 years, 10 months ago (2015-06-18 19:26:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197433002/1
4 years, 10 months ago (2015-06-18 21:01:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 22:22:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197402

Powered by Google App Engine
This is Rietveld 408576698