Issue 119743002: Make WebView work with either enteredViewCallback or attachedCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 119743002: Make WebView work with either enteredViewCallback or attachedCallback. (Closed)

Created:
7 years ago by dominicc (has gone to gerrit)

Modified:
7 years ago

Reviewers:
Fady Samuel

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make WebView work with either enteredViewCallback or attachedCallback. The Custom Elements enteredViewCallback is being renamed to attachedCallback. This sets up both properties for WebView. After the Blink-side renaming, the enteredViewCallback property can be removed. BUG=180965 TEST=WebViewTest.*,WebViewInteractiveTest.* R=fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242023

Patch Set 1 #

Patch Set 2 : Retry upload. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	chrome/renderer/resources/extensions/web_view.js	View		2 chunks	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

PTAL FYI the Blink-side change is under review at https://codereview.chromium.org/117313008/

7 years ago (2013-12-20 04:02:20 UTC) #1

dominicc (has gone to gerrit)

7 years ago (2013-12-20 05:15:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r242023 (presubmit successful).

Expand Messages | Collapse Messages