Issue 1197333002: Make the checkbox in settings control the radio buttons in the drawer, to demonstrate how to link s…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1197333002: Make the checkbox in settings control the radio buttons in the drawer, to demonstrate how to link s… (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make the checkbox in settings control the radio buttons in the drawer, to demonstrate how to link state in different places in an app. R=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b8da0f2f26512f939b1e8c38bb13c9f3a05482b7

Patch Set 2 : #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -29 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View	1	2 chunks	+25 lines, -12 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_home.dart	View	1	3 chunks	+15 lines, -9 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_settings.dart	View	1	2 chunks	+27 lines, -8 lines	0 comments	Download
A	sky/examples/stocks2/lib/stock_types.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jackson

lgtm https://codereview.chromium.org/1197333002/diff/1/sky/examples/stocks2/lib/stock_settings.dart File sky/examples/stocks2/lib/stock_settings.dart (right): https://codereview.chromium.org/1197333002/diff/1/sky/examples/stocks2/lib/stock_settings.dart#newcode15 sky/examples/stocks2/lib/stock_settings.dart:15: import 'stock_home.dart'; I don't think the settings page ...

5 years, 6 months ago (2015-06-23 00:44:03 UTC) #2

Hixie

5 years, 6 months ago (2015-06-23 16:54:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b8da0f2f26512f939b1e8c38bb13c9f3a05482b7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1197333002: Make the checkbox in settings control the radio buttons in the drawer, to demonstrate how to link s… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages