Chromium Code Reviews| Index: sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart |
| diff --git a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart |
| index ee8927027aa8106d2ddbeac2f4b803df9bca230d..b138b374c5a2763a7ef5821cb640f1261c418f10 100644 |
| --- a/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart |
| +++ b/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart |
| @@ -6,6 +6,11 @@ library _isolate_helper; |
| import 'dart:async'; |
| import 'dart:isolate'; |
| +import 'dart:_js_helper' show Null; |
| +import 'dart:_foreign_helper' show DART_CLOSURE_TO_JS, |
| + JS, |
| + JS_CREATE_ISOLATE, |
| + JS_SET_CURRENT_ISOLATE; |
| ReceivePort lazyPort; |
| @@ -490,22 +495,6 @@ class IsolateNatives { |
| JS("void", r"#.console.log(#)", globalThis, msg); |
| } |
| - /** |
| - * Extract the constructor of runnable, so it can be allocated in another |
| - * isolate. |
| - */ |
| - static dynamic _getJSConstructor(Isolate runnable) { |
|
ahe
2013/01/16 18:13:41
Intentional change?
Johnni Winther
2013/01/22 13:35:53
It popped up as invalid and, by Nicolas' account,
|
| - return JS("", "#.constructor", runnable); |
| - } |
| - |
| - /** Extract the constructor name of a runnable */ |
| - // TODO(sigmund): find a browser-generic way to support this. |
| - // TODO(floitsch): is this function still used? If yes, should we use |
| - // Primitives.objectTypeName instead? |
| - static dynamic _getJSConstructorName(Isolate runnable) { |
| - return JS("", "#.constructor.name", runnable); |
| - } |
| - |
| /** Find a constructor given its name. */ |
| static dynamic _getJSConstructorFromName(String factoryName) { |
| return JS("", r"$[#]", factoryName); |
| @@ -1266,7 +1255,7 @@ class TimerImpl implements Timer { |
| // event loop of the isolate library. The compiler makes sure |
| // that the event loop is compiled if [Timer] is used. |
| _globalState.topEventLoop.enqueue(_globalState.currentContext, () { |
| - callback(this); |
| + callback(this); |
| }, 'timer'); |
| } |
| } |