4 years, 10 months ago
(2015-06-23 06:33:47 UTC)
#2
please take a look.
haraken
Just a question, but would it be an option that we move ResourceClient to the ...
4 years, 10 months ago
(2015-06-23 06:37:56 UTC)
#3
Just a question, but would it be an option that we move ResourceClient to the
heap and mark it as EAGERLY_FINALIZE?
sof
On 2015/06/23 06:37:56, haraken wrote: > Just a question, but would it be an option ...
4 years, 10 months ago
(2015-06-23 06:41:28 UTC)
#4
On 2015/06/23 06:37:56, haraken wrote:
> Just a question, but would it be an option that we move ResourceClient to the
> heap and mark it as EAGERLY_FINALIZE?
You have non-heap objects that are clients, which makes this (and other Resource
changes) tricky. Like LayoutObject.
haraken
On 2015/06/23 06:41:28, sof wrote: > On 2015/06/23 06:37:56, haraken wrote: > > Just a ...
4 years, 10 months ago
(2015-06-23 06:42:54 UTC)
#5
On 2015/06/23 06:41:28, sof wrote:
> On 2015/06/23 06:37:56, haraken wrote:
> > Just a question, but would it be an option that we move ResourceClient to
the
> > heap and mark it as EAGERLY_FINALIZE?
>
> You have non-heap objects that are clients, which makes this (and other
Resource
> changes) tricky. Like LayoutObject.
Thanks, makes sense. LGTM.
sof
The CQ bit was checked by sigbjornf@opera.com
4 years, 10 months ago
(2015-06-23 09:43:12 UTC)
#6
Issue 1197283006: Oilpan: eagerly finalize SVGFEImageElement as an ImageResourceClient.
(Closed)
Created 4 years, 10 months ago by sof
Modified 4 years, 10 months ago
Reviewers: oilpan-reviews
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0