runtime/vm/intermediate_language.cc - Issue 1197263002: Fix crash in modPow (issue 23693); various bigint knowledge missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 1197263002: Fix crash in modPow (issue 23693); various bigint knowledge missing. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: c Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

diff --git a/runtime/vm/intermediate_language.cc b/runtime/vm/intermediate_language.cc

index fb55f660f397e597849ddd6bd71d4f0e290e08bf..cc17570f555e362f5e4bf34f2098477e93f7939e 100644

--- a/runtime/vm/intermediate_language.cc

+++ b/runtime/vm/intermediate_language.cc

@@ -1656,7 +1656,7 @@ RawInteger* BinaryIntegerOpInstr::Evaluate(const Integer& left,

case Token::kTRUNCDIV:

case Token::kMOD:

// Check right value for zero.

- if (right.AsInt64Value() == 0) {

+ if (right.IsSmi() && right.AsInt64Value() == 0) {

break; // Will throw.

}

// Fall through.

« no previous file with comments | « runtime/vm/constant_propagator.cc ('k') | tests/corelib/corelib.status » ('j') | tests/corelib/corelib.status » ('J')