Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1197243004: Replace some Tokenize calls with SplitString. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, James Su, sadrul, yusukes+watch_chromium.org, wfh+watch_chromium.org, devtools-reviews_chromium.org, shuchen+watch_chromium.org, yurys, nona+watch_chromium.org, rginda+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, pfeldman, tracing+reviews_chromium.org, kalyank, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, android-webview-reviews_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace some Tokenize calls with SplitString. Tokenize is now a legacy wrapper around a particular variant of SplitString call. I want to remove the Tokenize wrappers. This patch uses the StringPiece version in obvious cases which saves allocations, and in many places removes the vector temporary in preferences to a range-based for loop. Committed: https://crrev.com/37fd9d7d258626d3a1bd6db9fc99c97f981c21b1 Cr-Commit-Position: refs/heads/master@{#335856}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fixes #

Patch Set 5 : Fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -105 lines) Patch
M android_webview/browser/aw_media_client_android.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M ash/display/display_info.cc View 1 2 3 chunks +16 lines, -10 lines 0 comments Download
M base/process/process_iterator_freebsd.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M base/process/process_iterator_linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/process/process_iterator_mac.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M base/process/process_iterator_openbsd.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M base/process/process_metrics_linux.cc View 1 4 chunks +16 lines, -20 lines 0 comments Download
M base/strings/string_util.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/test_reg_util_win.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_test_helper.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/devtools/device/adb/adb_client_socket.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/adb/adb_device_provider.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/devtools/device/adb/mock_adb_server.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/devtools/device/android_device_info_query.cc View 1 2 5 chunks +29 lines, -25 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197243004/20001
5 years, 6 months ago (2015-06-23 00:55:08 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/50383)
5 years, 6 months ago (2015-06-23 01:13:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197243004/40001
5 years, 6 months ago (2015-06-23 19:25:31 UTC) #6
brettw
5 years, 6 months ago (2015-06-23 19:27:16 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/50664)
5 years, 6 months ago (2015-06-23 19:52:55 UTC) #10
yzshen1
On 2015/06/23 19:52:55, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years, 6 months ago (2015-06-23 21:10:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197243004/60001
5 years, 6 months ago (2015-06-23 21:21:57 UTC) #14
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 22:14:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197243004/80001
5 years, 6 months ago (2015-06-23 23:57:09 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-24 02:07:24 UTC) #20
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 02:08:22 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/37fd9d7d258626d3a1bd6db9fc99c97f981c21b1
Cr-Commit-Position: refs/heads/master@{#335856}

Powered by Google App Engine
This is Rietveld 408576698