Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 119723003: Get weborigin to build within blink_platform target. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Get weborigin to build within blink_platform target. It does not build entirely yet, but get us closer. ../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp: In constructor 'WebCore::OriginAccessEntry::OriginAccessEntry(const WTF::String&, const WTF::String&, WebCore::OriginAccessEntry::SubdomainSetting, WebCore::OriginAccessEntry::IPAddressSetting)': ../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86: error: no matching function for call to 'blink::WebPublicSuffixList::getPublicSuffixLength(WTF::String&)' ../../third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.cpp:55:86: note: candidate is: ../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20: note: virtual size_t blink::WebPublicSuffixList::getPublicSuffixLength(const blink::WebString&) ../../third_party/WebKit/public/platform/WebPublicSuffixList.h:40:20: note: no known conversion for argument 1 from 'WTF::String' to 'const blink::WebString&' BUG=328717 TEST=gn, ninja -C out/Default blink_platform R=brettw@chromium.org TBR=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243886

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix indentation #

Total comments: 2

Patch Set 4 : just platform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -98 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 1 chunk +33 lines, -28 lines 0 comments Download
D tools/gn/secondary/third_party/WebKit/Source/weborigin/BUILD.gn View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
6 years, 11 months ago (2014-01-05 23:43:55 UTC) #1
brettw
lgtm https://codereview.chromium.org/119723003/diff/70001/tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn File tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn (right): https://codereview.chromium.org/119723003/diff/70001/tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn#newcode5 tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn:5: component("blink_platform") { Can you call this "platform" so ...
6 years, 11 months ago (2014-01-08 05:29:59 UTC) #2
tfarina
https://codereview.chromium.org/119723003/diff/70001/tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn File tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn (right): https://codereview.chromium.org/119723003/diff/70001/tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn#newcode5 tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn:5: component("blink_platform") { On 2014/01/08 05:29:59, brettw wrote: > Can ...
6 years, 11 months ago (2014-01-09 00:59:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/119723003/170001
6 years, 11 months ago (2014-01-09 01:06:17 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43963
6 years, 11 months ago (2014-01-09 01:47:35 UTC) #5
tfarina
TBRing Darin for that. Looks like src/OWNERS needs to be updated!
6 years, 11 months ago (2014-01-09 02:45:29 UTC) #6
tfarina
6 years, 11 months ago (2014-01-09 02:45:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/119723003/170001
6 years, 11 months ago (2014-01-09 02:48:25 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=114224
6 years, 11 months ago (2014-01-09 03:47:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/119723003/170001
6 years, 11 months ago (2014-01-09 12:50:58 UTC) #10
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 14:08:54 UTC) #11
Message was sent while issue was closed.
Change committed as 243886

Powered by Google App Engine
This is Rietveld 408576698