Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 11972003: [Android] Upload instrumentation results to flakiness dashboard. (Closed)

Created:
7 years, 11 months ago by frankf
Modified:
7 years, 11 months ago
Reviewers:
craigdh, Isaac (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

[Android] Upload instrumentation results to flakiness dashboard. Upload to the staging server and only on the FYI bot. BUG=150801 TEST=bb_run_bot_test.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177186

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed ilevy's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
frankf
7 years, 11 months ago (2013-01-16 02:46:05 UTC) #1
Isaac (away)
Looks good to me with a couple minor changes. You can verify the right thing ...
7 years, 11 months ago (2013-01-16 03:08:25 UTC) #2
Isaac (away)
Sorry, rietveld ate my comments! https://chromiumcodereview.appspot.com/11972003/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://chromiumcodereview.appspot.com/11972003/diff/1/build/android/buildbot/bb_device_steps.py#newcode285 build/android/buildbot/bb_device_steps.py:285: parser.add_option('--flakiness-dashboard-server', action='store_true', Could we ...
7 years, 11 months ago (2013-01-16 03:11:26 UTC) #3
frankf
--TESTING is awesome! https://codereview.chromium.org/11972003/diff/1/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/11972003/diff/1/build/android/buildbot/bb_device_steps.py#newcode285 build/android/buildbot/bb_device_steps.py:285: parser.add_option('--flakiness-dashboard-server', action='store_true', On 2013/01/16 03:11:26, Isaac ...
7 years, 11 months ago (2013-01-16 18:00:37 UTC) #4
craigdh
lgtm.
7 years, 11 months ago (2013-01-16 18:04:15 UTC) #5
Isaac (away)
7 years, 11 months ago (2013-01-16 18:43:02 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698