Issue 11972002: MIPS: Some more instrumentation to narrow down Failure leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11972002: MIPS: Some more instrumentation to narrow down Failure leaks. (Closed)

Created:
7 years, 11 months ago by palfia

Modified:
7 years, 11 months ago

Reviewers:
kisg, Paul Lind, danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

MIPS: Some more instrumentation to narrow down Failure leaks. Port r13341 (673c3243) Original commit message: The basic idea is to tag OOM-Failure objects with an ID indicating where they were created. This requires changes to equality comparisons. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=13395

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View		3 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

palfia

We saw your note in the commit message, but this commit currently breaks the MIPS ...

7 years, 11 months ago (2013-01-16 01:13:24 UTC) #1

LGTM, landing.

Expand Messages | Collapse Messages