Source/web/SuspendableScriptExecutor.h - Issue 1197163003: Oilpan: make SuspendableScriptExecutor safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/SuspendableScriptExecutor.h

Issue 1197163003: Oilpan: make SuspendableScriptExecutor safe. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: re-intro RefCountedGarbageCollected Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/SuspendableScriptExecutor.h

diff --git a/Source/web/SuspendableScriptExecutor.h b/Source/web/SuspendableScriptExecutor.h

index 476202050555924fba8a1ae72c6f50cb71c5b670..cafb6854e52bc84748bc59c0c6773dd9f2a0c296 100644

--- a/Source/web/SuspendableScriptExecutor.h

+++ b/Source/web/SuspendableScriptExecutor.h

@@ -24,6 +24,9 @@ public:

virtual void contextDestroyed() override;

+ // Eager finalization is needed to promptly stop this timer object.

+ // (see DOMTimer comment for more.)

+ EAGERLY_FINALIZE();

DECLARE_VIRTUAL_TRACE();

private:

@@ -33,6 +36,7 @@ private:

void run();

void executeAndDestroySelf();

+ void dispose();

RawPtrWillBeMember<LocalFrame> m_frame;

int m_worldID;