Move SetFastElementsCapacity into GrowCapacityAndConvert

Move SetFastElementsCapacity into GrowCapacityAndConvert

BUG=v8:4137
LOG=n

Committed: https://crrev.com/046e91dd1ab76d17f6ee3388947fc2c64a2d7ae6
Cr-Commit-Position: refs/heads/master@{#29222}

[Toon Verwaest, 2015-06-22 13:57:30]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2015-06-22 13:57:31]

ptal

[Jakob Kummerow, 2015-06-22 17:03:02]

LGTM with comments.

https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc#newcode1...
src/objects.cc:12428: DCHECK(!(value->IsSmi() &&
object->HasFastDoubleElements()));
AFAICS you can DCHECK(!object->HasFastDoubleElements()) here.

https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc#newcode1...
src/objects.cc:12673: if (introduces_holes && object->HasFastHoleyElements()) {
I think you want to keep the '!'.

[Toon Verwaest, 2015-06-22 18:31:01]

Addressed comments, landing.

https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc#newcode1...
src/objects.cc:12428: DCHECK(!(value->IsSmi() &&
object->HasFastDoubleElements()));
On 2015/06/22 17:03:02, Jakob wrote:
> AFAICS you can DCHECK(!object->HasFastDoubleElements()) here.

Done.

https://codereview.chromium.org/1197133003/diff/60001/src/objects.cc#newcode1...
src/objects.cc:12673: if (introduces_holes && object->HasFastHoleyElements()) {
On 2015/06/22 17:03:02, Jakob wrote:
> I think you want to keep the '!'.

Done.

[Toon Verwaest, 2015-06-22 18:31:06]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-06-22 18:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1197133003/#ps80001
(title: "Addressed comments")

[commit-bot: I haz the power, 2015-06-22 18:31:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197133003/80001

[commit-bot: I haz the power, 2015-06-22 22:28:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 22:28:53]

Try jobs failed on following builders:
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/5978)

[Toon Verwaest, 2015-06-23 08:38:01]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2015-06-23 08:38:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1197133003/#ps100001
(title: "Remove validation in growing, only validate when mutating")

[commit-bot: I haz the power, 2015-06-23 08:38:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197133003/100001

[Jakob Kummerow, 2015-06-23 08:49:06]

Patch set 7 still LGTM.

[Toon Verwaest, 2015-06-23 08:50:31]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-06-23 08:50:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1197133003/120001

[commit-bot: I haz the power, 2015-06-23 09:44:19]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-06-23 09:44:36]

Patchset 7 (id:??) landed as
https://crrev.com/046e91dd1ab76d17f6ee3388947fc2c64a2d7ae6
Cr-Commit-Position: refs/heads/master@{#29222}