chrome/browser/safe_browsing/safe_browsing_testserver.py - Issue 11971025: [sync] Divorce python sync test server chromiumsync.py from testserver.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_testserver.py

Issue 11971025: [sync] Divorce python sync test server chromiumsync.py from testserver.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Philippe's comments. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/chrome_test_server_spawner.py ('K') | « chrome/browser/automation/testing_automation_provider.cc ('k') | chrome/browser/sync/test/integration/sync_test.h » ('j') | net/test/local_test_server.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_testserver.py

diff --git a/chrome/browser/safe_browsing/safe_browsing_testserver.py b/chrome/browser/safe_browsing/safe_browsing_testserver.py

index 674bf5ae01a3f3809a69f7d094dc05f8c2191a86..8ea4de051c12fa626096865937c60a3965edefb2 100755

--- a/chrome/browser/safe_browsing/safe_browsing_testserver.py

+++ b/chrome/browser/safe_browsing/safe_browsing_testserver.py

@@ -1,5 +1,5 @@

#!/usr/bin/env python

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

@@ -35,12 +35,6 @@ class ServerRunner(testserver_base.TestServerRunner):

self.option_parser.add_option('--data-file', dest='data_file',

help='File containing safebrowsing test '

'data and expectations')

- # TODO(mattm): we define an unnecessary --data-dir option because

- # BaseTestServer unconditionally sets --data-dir. This should be removed

- # when BaseTestServer is refactored to not contain all the net/

- # test_server.py specific stuff.

- self.option_parser.add_option('--data-dir', dest='data_dir',

- help='unused')

if __name__ == '__main__':