Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: tools/testing/dart/http_server.dart

Issue 11971012: Don't exit test script on an error in the http server. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/http_server.dart
===================================================================
--- tools/testing/dart/http_server.dart (revision 17127)
+++ tools/testing/dart/http_server.dart (working copy)
@@ -73,11 +73,8 @@
var httpServer = new HttpServer();
var packagesDirName = 'packages';
httpServer.onError = (e) {
- // Consider errors in the builtin http server fatal.
- // Intead of just throwing the exception we print
- // a message that makes it clearer what happened.
+ // TODO(ricow): Once we have a debug log we should write this out there.
print('Test http server error: $e');
- exit(1);
};
httpServer.defaultRequestHandler = (request, resp) {
var requestPath = new Path(request.path.substring(1)).canonicalize();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698