Issue 11971007: Pass ScopedJavaGlobalRef to bind() by value

Issue 11971007: Pass ScopedJavaGlobalRef to bind() by value (Closed)

Created:
7 years, 11 months ago by joth

Modified:
7 years, 10 months ago

Reviewers:
Avi (use Gerrit), benm (inactive)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, Avi (use Gerrit)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pass ScopedJavaGlobalRef to bind() by value ScopedJavaGlobalRef now has a copy constructor, so we can make the code simpler (no base::Owned() explanations) by just passing by value. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180624

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : avi comments #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -14 lines)			Patch
	M	android_webview/native/aw_contents.cc	View	1 2	1 chunk	+5 lines, -7 lines	0 comments	Download
	M	content/browser/android/content_view_core_impl.cc	View	1 2	2 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/11971007/1

7 years, 11 months ago (2013-01-19 02:00:16 UTC) #3

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 11 months ago (2013-01-19 02:18:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/11971007/16001

7 years, 11 months ago (2013-01-21 23:35:28 UTC) #6

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=76181

7 years, 11 months ago (2013-01-22 02:18:08 UTC) #7

Avi (use Gerrit)

https://chromiumcodereview.appspot.com/11971007/diff/16001/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): https://chromiumcodereview.appspot.com/11971007/diff/16001/content/browser/android/content_view_core_impl.cc#newcode1242 content/browser/android/content_view_core_impl.cc:1242: // when this base::Callback goes out of scope. You ...

7 years, 11 months ago (2013-01-22 02:21:41 UTC) #8

joth

https://codereview.chromium.org/11971007/diff/16001/content/browser/android/content_view_core_impl.cc File content/browser/android/content_view_core_impl.cc (right): https://codereview.chromium.org/11971007/diff/16001/content/browser/android/content_view_core_impl.cc#newcode1242 content/browser/android/content_view_core_impl.cc:1242: // when this base::Callback goes out of scope. On ...

7 years, 10 months ago (2013-02-05 00:30:29 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/11971007/27001

7 years, 10 months ago (2013-02-05 00:36:27 UTC) #11

Message was sent while issue was closed.

Change committed as 180624

Expand Messages | Collapse Messages