Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 1197033007: Added resource name mappings for new media playback UI. (Closed)

Created:
5 years, 6 months ago by liberato (no reviews please)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added resource name mappings for new media playback UI. This CL adds string mappings for new image and CSS assets for the new media playback UI. It does not change any existing functionality. It requires the assets to be checked into WebKit. BUG=446350, 488625, 487344 Committed: https://crrev.com/a8ce46eea4cd289b8c142b08f0c3efe6d4af9130 Cr-Commit-Position: refs/heads/master@{#336367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M components/html_viewer/blink_resource_constants.h View 3 chunks +17 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 11 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
liberato (no reviews please)
This is just name resource name mapping for the new media playback UI resources. It ...
5 years, 6 months ago (2015-06-23 16:51:39 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-24 14:46:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197033007/1
5 years, 6 months ago (2015-06-26 06:48:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/38368)
5 years, 6 months ago (2015-06-26 07:58:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1197033007/1
5 years, 6 months ago (2015-06-26 13:46:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-26 14:55:46 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 14:56:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8ce46eea4cd289b8c142b08f0c3efe6d4af9130
Cr-Commit-Position: refs/heads/master@{#336367}

Powered by Google App Engine
This is Rietveld 408576698