Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 11970022: Revert 177054 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gles2_implementation_unittest.cc
===================================================================
--- gpu/command_buffer/client/gles2_implementation_unittest.cc (revision 177244)
+++ gpu/command_buffer/client/gles2_implementation_unittest.cc (working copy)
@@ -248,6 +248,7 @@
}
void MockTransferBuffer::Free() {
+ GPU_NOTREACHED();
}
bool MockTransferBuffer::HaveBuffer() const {
@@ -1455,8 +1456,9 @@
uint32 offset = 0;
Cmds expected;
- int32 shm_id = command_buffer()->GetNextFreeTransferBufferId();
- expected.buf.Init(kTarget, kOffset, kSize, shm_id, offset);
+ expected.buf.Init(
+ kTarget, kOffset, kSize,
+ command_buffer()->GetNextFreeTransferBufferId(), offset);
expected.set_token.Init(GetNextToken());
void* mem = gl_->MapBufferSubDataCHROMIUM(
@@ -1464,11 +1466,6 @@
ASSERT_TRUE(mem != NULL);
gl_->UnmapBufferSubDataCHROMIUM(mem);
EXPECT_EQ(0, memcmp(&expected, commands_, sizeof(expected)));
-
- EXPECT_CALL(*command_buffer(), DestroyTransferBuffer(shm_id))
- .Times(1)
- .RetiresOnSaturation();
- gl_->FreeUnusedSharedMemory();
}
TEST_F(GLES2ImplementationTest, MapUnmapBufferSubDataCHROMIUMBadArgs) {
@@ -1523,10 +1520,10 @@
uint32 offset = 0;
Cmds expected;
- int32 shm_id = command_buffer()->GetNextFreeTransferBufferId();
expected.tex.Init(
GL_TEXTURE_2D, kLevel, kXOffset, kYOffset, kWidth, kHeight, kFormat,
- kType, shm_id, offset, GL_FALSE);
+ kType,
+ command_buffer()->GetNextFreeTransferBufferId(), offset, GL_FALSE);
expected.set_token.Init(GetNextToken());
void* mem = gl_->MapTexSubImage2DCHROMIUM(
@@ -1542,11 +1539,6 @@
ASSERT_TRUE(mem != NULL);
gl_->UnmapTexSubImage2DCHROMIUM(mem);
EXPECT_EQ(0, memcmp(&expected, commands_, sizeof(expected)));
-
- EXPECT_CALL(*command_buffer(), DestroyTransferBuffer(shm_id))
- .Times(1)
- .RetiresOnSaturation();
- gl_->FreeUnusedSharedMemory();
}
TEST_F(GLES2ImplementationTest, MapUnmapTexSubImage2DCHROMIUMBadArgs) {
@@ -2697,10 +2689,6 @@
gl_->GetQueryObjectuivEXT(id1, GL_QUERY_RESULT_AVAILABLE_EXT, &available);
EXPECT_TRUE(NoCommandsWritten());
EXPECT_EQ(0u, available);
-
- EXPECT_CALL(*command_buffer(), DestroyTransferBuffer(_))
- .Times(1)
- .RetiresOnSaturation();
}
TEST_F(GLES2ImplementationTest, ErrorQuery) {
@@ -2755,10 +2743,6 @@
gl_->GetQueryObjectuivEXT(id, GL_QUERY_RESULT_EXT, &result);
EXPECT_TRUE(NoCommandsWritten());
EXPECT_EQ(static_cast<GLuint>(GL_INVALID_ENUM), result);
-
- EXPECT_CALL(*command_buffer(), DestroyTransferBuffer(_))
- .Times(1)
- .RetiresOnSaturation();
}
#if !defined(GLES2_SUPPORT_CLIENT_SIDE_ARRAYS)
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698