Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: chromeos/docs/onc_spec.html

Issue 11970012: Add a check for server and CA certificates in device policies to the ONC validator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/docs/onc_spec.html
diff --git a/chromeos/docs/onc_spec.html b/chromeos/docs/onc_spec.html
index f715bae2ca61293203481c7009d32a4574e4b078..58ee8c5d448a01c574e5b7a303e579b187bf77c6 100644
--- a/chromeos/docs/onc_spec.html
+++ b/chromeos/docs/onc_spec.html
@@ -119,12 +119,12 @@
</p>
<p>
- GUIDs are meant to be stable and unique. When they refer to the same entity,
- they should be the same between ONC files. No two different networks or
- certificates should have the same GUID, similarly a network and certificate
- should not have the same GUID. A single ONC file should not contain the same
- entity twice (with the same GUID). Failing any of these tests indicates the
- ONC file is not valid.
+ GUIDs are non-empty strings that are meant to be stable and unique. When
+ they refer to the same entity, they should be the same between ONC files. No
+ two different networks or certificates should have the same GUID, similarly
+ a network and certificate should not have the same GUID. A single ONC file
+ should not contain the same entity twice (with the same GUID). Failing any
+ of these tests indicates the ONC file is not valid.
</p>
<p>
@@ -245,8 +245,9 @@
(required)
<span class="type">string</span>
</span>
- a unique identifier for this network connection, which exists to make it
- possible to update previously imported configurations
+ A unique identifier for this network connection, which exists to make it
+ possible to update previously imported configurations. Must have a length
pastarmovj 2013/01/16 14:49:38 Isn't "Must not be empty." Less robot sounding? :)
pneubeck (no reviews) 2013/01/16 14:53:18 I wanted to prevent that somebody may mix it up wi
+ greater than zero.
</dd>
<dt class="field">IPConfigs</dt>
@@ -1576,7 +1577,8 @@
(required)
<span class="type">string</span>
</span>
- unique identification for certificate
+ A unique identifier for this certificate. Must have a length greater than
+ zero.
</dd>
<dt class="field">PKCS12</dt>

Powered by Google App Engine
This is Rietveld 408576698