Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/chromeos/cros/network_library_unittest.cc

Issue 11970012: Add a check for server and CA certificates in device policies to the ONC validator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cert.h> 5 #include <cert.h>
6 #include <pk11pub.h> 6 #include <pk11pub.h>
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 cros_->ConnectToWifiNetwork(wifi1); 316 cros_->ConnectToWifiNetwork(wifi1);
317 EXPECT_TRUE(wifi1->connected()); 317 EXPECT_TRUE(wifi1->connected());
318 } 318 }
319 319
320 TEST_F(NetworkLibraryStubTest, NetworkConnectWifiWithCertPattern) { 320 TEST_F(NetworkLibraryStubTest, NetworkConnectWifiWithCertPattern) {
321 scoped_ptr<base::DictionaryValue> onc_root = 321 scoped_ptr<base::DictionaryValue> onc_root =
322 onc::test_utils::ReadTestDictionary("toplevel_wifi_eap_clientcert.onc"); 322 onc::test_utils::ReadTestDictionary("toplevel_wifi_eap_clientcert.onc");
323 base::ListValue* certificates; 323 base::ListValue* certificates;
324 onc_root->GetListWithoutPathExpansion(onc::kCertificates, &certificates); 324 onc_root->GetListWithoutPathExpansion(onc::kCertificates, &certificates);
325 325
326 onc::CertificateImporter importer(onc::ONC_SOURCE_USER_IMPORT, 326 onc::CertificateImporter importer(false /* don't allow webtrust */);
327 false /* don't allow webtrust */);
328 ASSERT_EQ(onc::CertificateImporter::IMPORT_OK, 327 ASSERT_EQ(onc::CertificateImporter::IMPORT_OK,
329 importer.ParseAndStoreCertificates(*certificates)); 328 importer.ParseAndStoreCertificates(*certificates));
330 329
331 WifiNetwork* wifi = cros_->FindWifiNetworkByPath("wifi_cert_pattern"); 330 WifiNetwork* wifi = cros_->FindWifiNetworkByPath("wifi_cert_pattern");
332 331
333 StubEnrollmentDelegate* enrollment_delegate = new StubEnrollmentDelegate(); 332 StubEnrollmentDelegate* enrollment_delegate = new StubEnrollmentDelegate();
334 wifi->SetEnrollmentDelegate(enrollment_delegate); 333 wifi->SetEnrollmentDelegate(enrollment_delegate);
335 EXPECT_FALSE(enrollment_delegate->did_enroll); 334 EXPECT_FALSE(enrollment_delegate->did_enroll);
336 EXPECT_FALSE(enrollment_delegate->correct_args); 335 EXPECT_FALSE(enrollment_delegate->correct_args);
337 336
338 ASSERT_NE(static_cast<const WifiNetwork*>(NULL), wifi); 337 ASSERT_NE(static_cast<const WifiNetwork*>(NULL), wifi);
339 EXPECT_FALSE(wifi->connected()); 338 EXPECT_FALSE(wifi->connected());
340 EXPECT_TRUE(cros_->CanConnectToNetwork(wifi)); 339 EXPECT_TRUE(cros_->CanConnectToNetwork(wifi));
341 EXPECT_FALSE(wifi->connected()); 340 EXPECT_FALSE(wifi->connected());
342 wifi->AttemptConnection( 341 wifi->AttemptConnection(
343 base::Bind(&WifiNetworkConnectCallback, cros_, wifi)); 342 base::Bind(&WifiNetworkConnectCallback, cros_, wifi));
344 EXPECT_TRUE(wifi->connected()); 343 EXPECT_TRUE(wifi->connected());
345 EXPECT_TRUE(enrollment_delegate->did_enroll); 344 EXPECT_TRUE(enrollment_delegate->did_enroll);
346 EXPECT_TRUE(enrollment_delegate->correct_args); 345 EXPECT_TRUE(enrollment_delegate->correct_args);
347 } 346 }
348 347
349 TEST_F(NetworkLibraryStubTest, NetworkConnectVPNWithCertPattern) { 348 TEST_F(NetworkLibraryStubTest, NetworkConnectVPNWithCertPattern) {
350 scoped_ptr<base::DictionaryValue> onc_root = 349 scoped_ptr<base::DictionaryValue> onc_root =
351 onc::test_utils::ReadTestDictionary("toplevel_openvpn_clientcert.onc"); 350 onc::test_utils::ReadTestDictionary("toplevel_openvpn_clientcert.onc");
352 base::ListValue* certificates; 351 base::ListValue* certificates;
353 onc_root->GetListWithoutPathExpansion(onc::kCertificates, &certificates); 352 onc_root->GetListWithoutPathExpansion(onc::kCertificates, &certificates);
354 353
355 onc::CertificateImporter importer(onc::ONC_SOURCE_USER_IMPORT, 354 onc::CertificateImporter importer(false /* don't allow webtrust */);
356 false /* don't allow webtrust */);
357 ASSERT_EQ(onc::CertificateImporter::IMPORT_OK, 355 ASSERT_EQ(onc::CertificateImporter::IMPORT_OK,
358 importer.ParseAndStoreCertificates(*certificates)); 356 importer.ParseAndStoreCertificates(*certificates));
359 357
360 VirtualNetwork* vpn = cros_->FindVirtualNetworkByPath("vpn_cert_pattern"); 358 VirtualNetwork* vpn = cros_->FindVirtualNetworkByPath("vpn_cert_pattern");
361 359
362 StubEnrollmentDelegate* enrollment_delegate = new StubEnrollmentDelegate(); 360 StubEnrollmentDelegate* enrollment_delegate = new StubEnrollmentDelegate();
363 vpn->SetEnrollmentDelegate(enrollment_delegate); 361 vpn->SetEnrollmentDelegate(enrollment_delegate);
364 EXPECT_FALSE(enrollment_delegate->did_enroll); 362 EXPECT_FALSE(enrollment_delegate->did_enroll);
365 EXPECT_FALSE(enrollment_delegate->correct_args); 363 EXPECT_FALSE(enrollment_delegate->correct_args);
366 364
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 492
495 // TODO(stevenjb): Test network profiles. 493 // TODO(stevenjb): Test network profiles.
496 494
497 // TODO(stevenjb): Test network devices. 495 // TODO(stevenjb): Test network devices.
498 496
499 // TODO(stevenjb): Test data plans. 497 // TODO(stevenjb): Test data plans.
500 498
501 // TODO(stevenjb): Test monitor network / device. 499 // TODO(stevenjb): Test monitor network / device.
502 500
503 } // namespace chromeos 501 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698