Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2699)

Unified Diff: chrome/browser/net/client_hints_unittest.cc

Issue 11970002: Added Client-Hints. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Made float literals explicit in tests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/client_hints.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/client_hints_unittest.cc
diff --git a/chrome/browser/net/client_hints_unittest.cc b/chrome/browser/net/client_hints_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0846a6dbc3198d9ddaa4309761f48de2b7445c40
--- /dev/null
+++ b/chrome/browser/net/client_hints_unittest.cc
@@ -0,0 +1,45 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/client_hints.h"
+
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ClientHintsTest : public testing::Test {
+ public:
+ void UpdateScreenInfo(int width, int height, float pixel_ratio) {
+ ClientHints::ScreenInfo info;
+ info.width = width;
+ info.height = height;
+ info.pixel_ratio = pixel_ratio;
+ client_hints_.UpdateScreenInfo(&info);
+ };
+
+ protected:
+ ClientHints client_hints_;
+};
+
+TEST_F(ClientHintsTest, HintsWellFormatted) {
+ UpdateScreenInfo(100, 200, 1.567f);
+ std::string hint = client_hints_.GetScreenInfoHints();
+ EXPECT_EQ("dh=200, dw=100, dpr=1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsHaveNonbogusValues) {
+ UpdateScreenInfo(-100, -200, -1.567f);
+ std::string hint = client_hints_.GetScreenInfoHints();
+ EXPECT_EQ("", hint);
+
+ UpdateScreenInfo(100, 200, 1.567f);
+ hint = client_hints_.GetScreenInfoHints();
+ EXPECT_EQ("dh=200, dw=100, dpr=1.57", hint);
+
+ UpdateScreenInfo(100, 200, 0.0f);
+ hint = client_hints_.GetScreenInfoHints();
+ // Hints should be last known good values.
+ EXPECT_EQ("dh=200, dw=100, dpr=1.57", hint);
+}
+
« no previous file with comments | « chrome/browser/net/client_hints.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698