Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Side by Side Diff: chrome/browser/net/client_hints_unittest.cc

Issue 11970002: Added Client-Hints. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed RefCountedThreadSafe, added tests. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/net/client_hints.h"
6
7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 class ClientHintsTest : public testing::Test {
12 public:
13 void UpdateScreenInfo(int width, int height, float pixel_ratio) {
14 ClientHints::ScreenInfo info;
15 info.width = width;
16 info.height = height;
17 info.pixel_ratio = pixel_ratio;
18 client_hints_.UpdateScreenInfo(&info);
19 };
20 protected:
21 ClientHints client_hints_;
22 };
23
24 TEST_F(ClientHintsTest, HintsWellFormatted) {
25 UpdateScreenInfo(100, 200, 1.567);
26 std::string hint = client_hints_.GetScreenInfoHints();
27 EXPECT_EQ("dh=200, dw=100, dpr=1.57", hint);
28 }
29
30 TEST_F(ClientHintsTest, HintsHaveNonbogusValues) {
31 UpdateScreenInfo(-100, -200, -1.567);
32 std::string hint = client_hints_.GetScreenInfoHints();
33 EXPECT_EQ("", hint);
34
35 UpdateScreenInfo(100, 200, 1.567);
36 hint = client_hints_.GetScreenInfoHints();
37 EXPECT_EQ("dh=200, dw=100, dpr=1.57", hint);
38
39 UpdateScreenInfo(100, 200, 0.0);
40 hint = client_hints_.GetScreenInfoHints();
41 // Hints should be last known good values.
42 EXPECT_EQ("dh=200, dw=100, dpr=1.57", hint);
43
44 }
45
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698