Issue 11969037: Remove unused GlobalHandles::IterateWeakRoots()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11969037: Remove unused GlobalHandles::IterateWeakRoots() (Closed)

Created:
7 years, 11 months ago by haraken

Modified:
7 years, 11 months ago

Reviewers:
Michael Starzinger, danno

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Remove unused GlobalHandles::IterateWeakRoots() BUG= Committed: http://code.google.com/p/v8/source/detail?r=13445

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	src/global-handles.h	View		1 chunk	+0 lines, -4 lines	1 comment	Download
	M	src/global-handles.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

haraken

This is just a preparation patch for https://chromiumcodereview.appspot.com/11959031/ michael: Would you take a look? (If ...

7 years, 11 months ago (2013-01-17 11:50:19 UTC) #1

Michael Starzinger

7 years, 11 months ago (2013-01-21 12:22:51 UTC) #2

LGTM. I'll land this. One comment which I will address while landing.

https://chromiumcodereview.appspot.com/11969037/diff/1/src/global-handles.h
File src/global-handles.h (left):

https://chromiumcodereview.appspot.com/11969037/diff/1/src/global-handles.h#o...
src/global-handles.h:187: void IterateWeakRoots(WeakReferenceGuest f,
AFAICT we can get rid of the WeakReferenceGuest type definition as well, nobody
seems to use it anymore.

Expand Messages | Collapse Messages