Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: gdb/testsuite/gdb.trace/circ.exp

Issue 11969036: Merge GDB 7.5.1 (Closed) Base URL: http://git.chromium.org/native_client/nacl-gdb.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gdb/testsuite/gdb.trace/circ.c ('k') | gdb/testsuite/gdb.trace/collection.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gdb/testsuite/gdb.trace/circ.exp
diff --git a/gdb/testsuite/gdb.trace/circ.exp b/gdb/testsuite/gdb.trace/circ.exp
index 7d79d0484e0af18a810ff27ceccc027924fe4d06..830008224836ddbc6cb9cfd765090cde605245d7 100644
--- a/gdb/testsuite/gdb.trace/circ.exp
+++ b/gdb/testsuite/gdb.trace/circ.exp
@@ -15,18 +15,10 @@
load_lib "trace-support.exp"
-if $tracelevel then {
- strace $tracelevel
-}
-
-set testfile "circ"
-set srcfile ${testfile}.c
-set binfile $objdir/$subdir/$testfile
+standard_testfile
-if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
- executable {debug nowarnings}] != "" } {
- untested circ.exp
+if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug nowarnings}]} {
return -1
}
@@ -92,26 +84,45 @@ proc setup_tracepoints { } {
# return 0 for success, 1 for failure
proc trace_buffer_normal { } {
- if [gdb_test "maint packet QTBuffer:size:ffffffff" \
- "received: .OK." ""] then {
- pass "This test cannot be run on this target"
+ global gdb_prompt
+
+ set ok 0
+ set test "maint packet QTBuffer:size:ffffffff"
+ gdb_test_multiple $test $test {
+ -re "received: .OK.\r\n$gdb_prompt $" {
+ set ok 1
+ pass $test
+ }
+ -re "\r\n$gdb_prompt $" {
+ }
+ }
+ if { !$ok } {
+ unsupported $test
return 1;
}
- if [gdb_test "maint packet QTBuffer:circular:0" \
- "received: .OK." ""] then {
- pass "This test cannot be run on this target"
+
+ set ok 0
+ set test "maint packet QTBuffer:circular:0"
+ gdb_test_multiple $test $test {
+ -re "received: .OK.\r\n$gdb_prompt $" {
+ set ok 1
+ pass $test
+ }
+ -re "\r\n$gdb_prompt $" {
+ }
+ }
+ if { !$ok } {
+ unsupported $test
return 1;
}
+
return 0;
}
# return 0 for success, 1 for failure
proc gdb_trace_circular_tests { } {
-
- # We generously give ourselves one "pass" if we successfully
- # detect that this test cannot be run on this target!
if { ![gdb_target_supports_trace] } then {
- pass "Current target does not support trace"
+ unsupported "Current target does not support trace"
return 1;
}
@@ -185,17 +196,6 @@ proc gdb_trace_circular_tests { } {
return 0;
}
-# Start with a fresh gdb.
-
-gdb_exit
-gdb_start
-gdb_reinitialize_dir $srcdir/$subdir
-gdb_load $binfile
-
-if [target_info exists gdb_stub] {
- gdb_step_for_stub;
-}
-
gdb_test_no_output "set circular-trace-buffer on" \
"set circular-trace-buffer on"
« no previous file with comments | « gdb/testsuite/gdb.trace/circ.c ('k') | gdb/testsuite/gdb.trace/collection.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698