Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: gdb/testsuite/gdb.base/gnu-ifunc.exp

Issue 11969036: Merge GDB 7.5.1 (Closed) Base URL: http://git.chromium.org/native_client/nacl-gdb.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gdb/testsuite/gdb.base/gdbvars.exp ('k') | gdb/testsuite/gdb.base/gnu_vector.exp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gdb/testsuite/gdb.base/gnu-ifunc.exp
diff --git a/gdb/testsuite/gdb.base/gnu-ifunc.exp b/gdb/testsuite/gdb.base/gnu-ifunc.exp
index a92c3544afe40f28e68f2a1ea385d5e38eed99cc..a8b967aebdf43e51f9d30b6b11d742966e01e613 100644
--- a/gdb/testsuite/gdb.base/gnu-ifunc.exp
+++ b/gdb/testsuite/gdb.base/gnu-ifunc.exp
@@ -48,7 +48,7 @@ set lib_o ${objdir}/${subdir}/${libfile}.o
set lib_opts {}
set exec_opts [list debug shlib=$lib_so]
-if [get_compiler_info ${binfile}] {
+if [get_compiler_info] {
return -1
}
@@ -127,20 +127,17 @@ gdb_test "info sym $expect_out(1,string)" "gnu_ifunc in section .*" "info sym <g
# Test statically linked ifunc resolving during inferior start.
# https://bugzilla.redhat.com/show_bug.cgi?id=624967
-if ![target_info exists gdb_stub] {
+# Compile $staticbinfile separately as it may exit on error (ld/12595).
- # Compile $staticbinfile separately as it may exit on error (ld/12595).
-
- if { [gdb_compile ${srcdir}/${subdir}/$libsrc $lib_o object {}] != ""
- || [gdb_compile "${srcdir}/${subdir}/$srcfile $lib_o" $staticbinfile executable {debug}] != "" } {
- untested "Could not compile static executable $staticbinfile."
- return -1
- }
+if { [gdb_compile ${srcdir}/${subdir}/$libsrc $lib_o object {}] != ""
+ || [gdb_compile "${srcdir}/${subdir}/$srcfile $lib_o" $staticbinfile executable {debug}] != "" } {
+ untested "Could not compile static executable $staticbinfile."
+ return -1
+}
- clean_restart $staticexecutable
+clean_restart $staticexecutable
- gdb_breakpoint "gnu_ifunc"
- gdb_breakpoint "main"
- gdb_run_cmd
- gdb_test "" "Breakpoint \[0-9\]*, main .*" "static gnu_ifunc"
-}
+gdb_breakpoint "gnu_ifunc"
+gdb_breakpoint "main"
+gdb_run_cmd
+gdb_test "" "Breakpoint \[0-9\]*, main .*" "static gnu_ifunc"
« no previous file with comments | « gdb/testsuite/gdb.base/gdbvars.exp ('k') | gdb/testsuite/gdb.base/gnu_vector.exp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698