Merge GDB 7.5.1

gdb/objfiles.h

 /* Definitions for symbol file management in GDB.
 
    Copyright (C) 1992-2004, 2007-2012 Free Software Foundation, Inc.
 
    This file is part of GDB.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
@@ skipping 309 matching lines @@
 
     /* Per objfile data-pointers required by other GDB modules.  */
     /* FIXME: kettenis/20030711: This mechanism could replace
        deprecated_sym_stab_info and deprecated_sym_private
        entirely.  */
 
     void **data;
     unsigned num_data;
 
     /* Set of relocation offsets to apply to each section.
-       Currently on the objfile_obstack (which makes no sense, but I'm
-       not sure it's harming anything).
+       The table is indexed by the_bfd_section->index, thus it is generally
+       as large as the number of sections in the binary.
+       The table is stored on the objfile_obstack.
 
        These offsets indicate that all symbols (including partial and
        minimal symbols) which have been read have been relocated by this
-       much.  Symbols which are yet to be read need to be relocated by
-       it.  */
+       much.  Symbols which are yet to be read need to be relocated by it.  */
 
     struct section_offsets *section_offsets;
     int num_sections;
 
     /* Indexes in the section_offsets array.  These are initialized by the
        *_symfile_offsets() family of functions (som_symfile_offsets,
        xcoff_symfile_offsets, default_symfile_offsets).  In theory they
        should correspond to the section indexes used by bfd for the
        current objfile.  The exception to this for the time being is the
        SOM version.  */
 
     int sect_index_text;
     int sect_index_data;
     int sect_index_bss;
     int sect_index_rodata;
 
     /* These pointers are used to locate the section table, which
        among other things, is used to map pc addresses into sections.
        SECTIONS points to the first entry in the table, and
        SECTIONS_END points to the first location past the last entry
-       in the table.  Currently the table is stored on the
-       objfile_obstack (which makes no sense, but I'm not sure it's
-       harming anything).  */
+       in the table.  The table is stored on the objfile_obstack.
+       There is no particular order to the sections in this table, and it
+       only contains sections we care about (e.g. non-empty, SEC_ALLOC).  */
 
-    struct obj_section
-     *sections, *sections_end;
+    struct obj_section *sections, *sections_end;
 
     /* GDB allows to have debug symbols in separate object files.  This is
        used by .gnu_debuglink, ELF build id note and Mach-O OSO.
        Although this is a tree structure, GDB only support one level
        (ie a separate debug for a separate debug is not supported).  Note that
        separate debug object are in the main chain and therefore will be
        visited by ALL_OBJFILES & co iterators.  Separate debug objfile always
        has a non-nul separate_debug_objfile_backlink.  */
 
     /* Link to the first separate debug object, if any.  */
     struct objfile *separate_debug_objfile;
 
     /* If this is a separate debug object, this is used as a link to the
        actual executable objfile.  */
     struct objfile *separate_debug_objfile_backlink;
 
     /* If this is a separate debug object, this is a link to the next one
        for the same executable objfile.  */
     struct objfile *separate_debug_objfile_link;
 
     /* Place to stash various statistics about this objfile.  */
-      OBJSTATS;
+    OBJSTATS;
 
     /* A linked list of symbols created when reading template types or
        function templates.  These symbols are not stored in any symbol
        table, so we have to keep them here to relocate them
        properly.  */
     struct symbol *template_symbols;
   };
 
 /* Defines for the objfile flag word.  */
 
@@ skipping 48 matching lines @@
 extern struct objfile *allocate_objfile (bfd *, int);
 
 extern struct gdbarch *get_objfile_arch (struct objfile *);
 
 extern void init_entry_point_info (struct objfile *);
 
 extern int entry_point_address_query (CORE_ADDR *entry_p);
 
 extern CORE_ADDR entry_point_address (void);
 
-extern int build_objfile_section_table (struct objfile *);
+extern void build_objfile_section_table (struct objfile *);
 
 extern void terminate_minimal_symbol_table (struct objfile *objfile);
 
 extern struct objfile *objfile_separate_debug_iterate (const struct objfile *,
                                                        const struct objfile *);
 
 extern void put_objfile_before (struct objfile *, struct objfile *);
 
 extern void objfile_to_front (struct objfile *);
 
@@ skipping 52 matching lines @@
 extern const struct objfile_data *register_objfile_data_with_cleanup
   (void (*save) (struct objfile *, void *),
    void (*free) (struct objfile *, void *));
 
 extern void clear_objfile_data (struct objfile *objfile);
 extern void set_objfile_data (struct objfile *objfile,
                               const struct objfile_data *data, void *value);
 extern void *objfile_data (struct objfile *objfile,
                            const struct objfile_data *data);