Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2980)

Unified Diff: chrome/app/chrome_main_delegate.cc

Issue 11969025: Enable breakpad building by default on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix assuming linux_breakpad->on Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/app/chrome_main_delegate.cc
diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc
index f044ef8c42b33b57da89bf1008b61a7fe7c44b34..040684101624093d8035e190795e98aa07269600 100644
--- a/chrome/app/chrome_main_delegate.cc
+++ b/chrome/app/chrome_main_delegate.cc
@@ -639,16 +639,7 @@ void ChromeMainDelegate::PreSandboxStartup() {
// need to call InitCrashReporter() in RunZygote().
if (!process_type.empty() && process_type != switches::kZygoteProcess) {
#if defined(OS_ANDROID)
- // On Android we need to provide a FD to the file where the minidump is
- // generated as the renderer and browser run with different UIDs
- // (preventing the browser from inspecting the renderer process).
- int minidump_fd = base::GlobalDescriptors::GetInstance()->
- MaybeGet(kAndroidMinidumpDescriptor);
- if (minidump_fd == base::kInvalidPlatformFileValue) {
- NOTREACHED() << "Could not find minidump FD, crash reporting disabled.";
- } else {
- InitNonBrowserCrashReporterForAndroid(minidump_fd);
- }
+ InitNonBrowserCrashReporterForAndroid();
#else
InitCrashReporter();
#endif

Powered by Google App Engine
This is Rietveld 408576698