Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1196853002: Cleanup: Remove dead formfiller code. (Closed)

Created:
5 years, 6 months ago by Lei Zhang
Modified:
5 years, 6 months ago
Reviewers:
jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -224 lines) Patch
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_FormFiller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_IFormFiller.h View 3 chunks +0 lines, -23 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_TextField.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_ComboBox.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 4 chunks +0 lines, -28 lines 1 comment Download
M fpdfsdk/src/formfiller/FFL_IFormFiller.cpp View 6 chunks +0 lines, -130 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Wnd.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
https://codereview.chromium.org/1196853002/diff/1/fpdfsdk/src/formfiller/FFL_FormFiller.cpp File fpdfsdk/src/formfiller/FFL_FormFiller.cpp (left): https://codereview.chromium.org/1196853002/diff/1/fpdfsdk/src/formfiller/FFL_FormFiller.cpp#oldcode228 fpdfsdk/src/formfiller/FFL_FormFiller.cpp:228: FX_BOOL CFFL_FormFiller::OnRButtonDblClk(CPDFSDK_PageView *pPageView, CPDFSDK_Annot* pAnnot, FX_UINT nFlags, const CPDF_Point& ...
5 years, 6 months ago (2015-06-22 01:24:38 UTC) #2
jam
lgtm
5 years, 6 months ago (2015-06-22 16:22:09 UTC) #3
Lei Zhang
5 years, 6 months ago (2015-06-22 22:09:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2d3911ce1a07812d75e7671e038d0922a823528 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698