chrome/renderer/extensions/user_script_scheduler.cc - Issue 11968054: <webview>: Implement ExecuteScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/user_script_scheduler.cc

Issue 11968054: <webview>: Implement ExecuteScript (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed nits Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/user_script_scheduler.cc

diff --git a/chrome/renderer/extensions/user_script_scheduler.cc b/chrome/renderer/extensions/user_script_scheduler.cc

index 96da900f3382ddde587d7f081d6a5825f5b577bd..0e6f766e49e3c4a39d188fc71216b610ed517757 100644

--- a/chrome/renderer/extensions/user_script_scheduler.cc

+++ b/chrome/renderer/extensions/user_script_scheduler.cc

@@ -175,7 +175,8 @@ void UserScriptScheduler::ExecuteCodeImpl(

// For child frames, we just skip ones the extension doesn't have access

// to and carry on.

- if (!extension->CanExecuteScriptOnPage(child_frame->document().url(),

+ if (!params.is_web_view &&

not at google - send to devlin 2013/01/25 22:04:14 I'm trying to understand the code here. Why no che

+ !extension->CanExecuteScriptOnPage(child_frame->document().url(),

frame_->document().url(),

extension_helper->tab_id(),

NULL,