chrome/browser/extensions/api/tabs/tabs_api.cc - Issue 11968054: <webview>: Implement ExecuteScript

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 11968054: <webview>: Implement ExecuteScript (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Updated stale browser_plugin_messages.h Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc

index 441f4221875776e3e7289624cdabc30fca17936f..e7e92f73e88c7fc0598eee30ec36df6462503327 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc

@@ -1388,6 +1388,7 @@ bool TabsUpdateFunction::UpdateURLIfPresent(DictionaryValue* update_props,

ScriptExecutor::TOP_FRAME,

extensions::UserScript::DOCUMENT_IDLE,

ScriptExecutor::MAIN_WORLD,

+ false /* is_web_view */,

base::Bind(&TabsUpdateFunction::OnExecuteCodeFinished, this));

*is_async = true;

@@ -2131,6 +2132,7 @@ bool ExecuteCodeInTabFunction::Execute(const std::string& code_string) {

frame_scope,

run_at,

ScriptExecutor::ISOLATED_WORLD,

+ false /* is_web_view */,

base::Bind(&ExecuteCodeInTabFunction::OnExecuteCodeFinished, this));

return true;

}