<webview>: Implement ExecuteScript

chrome/renderer/extensions/user_script_scheduler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/extensions/user_script_scheduler.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "chrome/common/extensions/extension_messages.h"
@@ skipping 157 matching lines @@
       // We recheck access here in the renderer for extra safety against races
       // with navigation.
       //
       // But different frames can have different URLs, and the extension might
       // only have access to a subset of them. For the top frame, we can
       // immediately send an error and stop because the browser process
       // considers that an error too.
       //
       // For child frames, we just skip ones the extension doesn't have access
       // to and carry on.
-      if (!extension->CanExecuteScriptOnPage(child_frame->document().url(),
+      if (!extension->is_app() &&

[Matt Perry, 2013/01/23 02:50:49]

This is not quite the right check.

Are we sure we want to let an embedder call webview.executeScript() no matter
what URL is loaded into that webview? What if we required the webview app to
list its host permissions before it can execute script on those hosts?

If we really need to bypass this check, we should do it in a manner more
specific to webview. That might mean modifying ScriptExecutor to pass down an
extra is_webview param.

[Fady Samuel, 2013/01/23 20:12:03]

Done.

+          !extension->CanExecuteScriptOnPage(child_frame->document().url(),
                                              frame_->document().url(),
                                              extension_helper->tab_id(),
                                              NULL,
                                              NULL)) {
         if (child_frame->parent()) {
           continue;
         } else {
           error = ErrorUtils::FormatErrorMessage(
               extension_manifest_errors::kCannotAccessPage,
               child_frame->document().url().spec());
@@ skipping 60 matching lines @@
 
   for (WebFrame* child_frame = parent_frame->firstChild(); child_frame;
        child_frame = child_frame->nextSibling()) {
     frames_vector->push_back(child_frame);
     GetAllChildFrames(child_frame, frames_vector);
   }
   return true;
 }
 
 }  // namespace extensions