Show dictionary changes in chrome://settings/editDictionary as changes come in

chrome/browser/resources/options/language_dictionary_overlay_word_list.js

Index: chrome/browser/resources/options/language_dictionary_overlay_word_list.js
diff --git a/chrome/browser/resources/options/language_dictionary_overlay_word_list.js b/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
index b1bff432ec30906a46c89874f9075ac023d3cc48..1c8dd17701b5c72fc68a475bafdb4c7803b79cf5 100644
--- a/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
+++ b/chrome/browser/resources/options/language_dictionary_overlay_word_list.js
@@ -98,7 +98,16 @@ cr.define('options.dictionary_words', function() {
     allWordsList_: null,
 
     /**
-     * Add a dictionary word.
+     * The list of words that have been removed from the dictionary, but we have

[James Hawkins, 2013/01/18 21:07:46]

nit: Avoid pronouns in comments, since pronouns are ambiguous.  Rephrasing to
remove the pronoun almost always produces a more readable comment.

[please use gerrit instead, 2013/01/18 23:34:53]

Done.

+     * not received a notification of their removal yet. Once we're notified of
+     * a word removal, we remove it from this list.
+     * @type {Array}
+     * @private
+     */
+    removedWordsList_: [],
+
+    /**
+     * Adds a dictionary word.
      * @param {string} dictionaryWord The word to add.
      * @private
      */
@@ -110,7 +119,7 @@ cr.define('options.dictionary_words', function() {
     },
 
     /**
-     * Search the list for the matching words.
+     * Searches the list for the matching words.
      * @param {string} searchTerm The search term.
      */
     search: function(searchTerm) {
@@ -124,7 +133,7 @@ cr.define('options.dictionary_words', function() {
     },
 
     /**
-     * Set the list of dictionary words.
+     * Sets the list of dictionary words.
      * @param {Array} entries The list of dictionary words.
      */
     setWordList: function(entries) {
@@ -136,7 +145,57 @@ cr.define('options.dictionary_words', function() {
     },
 
     /**
-     * True if the data model contains no words, otherwise false.
+     * Adds non-duplicate dictionary words.
+     * @param {Array} entries The list of dictionary words.
+     */
+    addWords: function(entries) {
+      var to_add = [];
+      for (var i = 0; i < entries.length; ++i) {

[James Hawkins, 2013/01/18 21:07:46]

i++ here and elsewhere.

[please use gerrit instead, 2013/01/18 23:34:53]

Done.

+        if (this.allWordsList_.indexOf(entries[i]) == -1) {
+          this.allWordsList_.push(entries[i]);
+          to_add.push(entries[i]);
+        }
+      }
+      if (to_add.length == 0)
+        return;
+      for (var i = 0; i < to_add.length; ++i)
+        this.dataModel.splice(this.dataModel.length - 1, 0, to_add[i]);
+      this.onWordListChanged();
+    },
+
+    /**
+     * Removes dictionary words that are not in |removedWordsList_|. If a word
+     * is in |removedWordsList_|, then removes the word from there instead.
+     * @param {Array} entries The list of dictionary words.
+     */
+    removeWords: function(entries) {
+      var index;
+      var to_remove = [];
+      for (var i = 0; i < entries.length; ++i) {
+        index = this.removedWordsList_.indexOf(entries[i]);
+        if (index > -1) {
+          this.removedWordsList_.splice(index, 1);
+        } else {
+          index = this.allWordsList_.indexOf(entries[i]);
+          if (index > -1) {
+            this.allWordsList_.splice(index, 1);
+            to_remove.push(entries[i]);
+          }
+        }
+      }
+      if (to_remove.length == 0)
+        return;
+      for (var i = 0; i < to_remove.length; ++i) {
+        index = this.dataModel.indexOf(to_remove[i]);
+        if (index > -1)
+          this.dataModel.splice(index, 1);
+      }
+      this.onWordListChanged();
+    },
+
+    /**
+     * Returns true if the data model contains no words, otherwise returns
+     * false.
      * @type {boolean}
      */
     get empty() {
@@ -162,6 +221,7 @@ cr.define('options.dictionary_words', function() {
       assert(allWordsListIndex > -1);
       this.allWordsList_.splice(allWordsListIndex, 1);
       this.dataModel.splice(index, 1);
+      this.removedWordsList_.push(item);
       this.onWordListChanged();
       chrome.send('removeDictionaryWord', [item]);
     },