Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/chromeos/login/user_image_loader.h

Issue 11968044: Fix login visual hitch on chromebook (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/user_image_loader.h
diff --git a/chrome/browser/chromeos/login/user_image_loader.h b/chrome/browser/chromeos/login/user_image_loader.h
index a5a8b4589c29016c79a2a2b9351f7516f923e010..895f5be43dd14383d5816a0b22d53699f5824259 100644
--- a/chrome/browser/chromeos/login/user_image_loader.h
+++ b/chrome/browser/chromeos/login/user_image_loader.h
@@ -11,6 +11,8 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
+#include "base/synchronization/lock.h"
+#include "base/threading/sequenced_worker_pool.h"
#include "chrome/browser/image_decoder.h"
class MessageLoop;
@@ -28,6 +30,8 @@ class UserImageLoader : public base::RefCountedThreadSafe<UserImageLoader>,
// Callback used to indicate that image has been loaded.
typedef base::Callback<void(const UserImage& user_image)> LoadedCallback;
+ typedef base::SequencedWorkerPool::SequenceToken SequenceToken;
Joao da Silva 2013/01/22 10:04:12 This can be moved to the .cc file.
bshe 2013/01/22 15:36:26 Done.
+
explicit UserImageLoader(ImageDecoder::ImageCodec image_codec);
// Start reading the image from |filepath| on the file thread. Calls
Nikita (slow) 2013/01/22 11:30:54 nit: Comment should be updated now.
bshe 2013/01/22 15:36:26 Done.
@@ -55,7 +59,9 @@ class UserImageLoader : public base::RefCountedThreadSafe<UserImageLoader>,
// Method that reads the file on the file thread and starts decoding it in
Nikita (slow) 2013/01/22 11:30:54 nit: Comment should be updated now.
bshe 2013/01/22 15:36:26 Done.
// sandboxed process.
- void LoadImage(const std::string& filepath, const ImageInfo& image_info);
+ void LoadImage(const std::string& filepath,
+ const ImageInfo& image_info,
+ scoped_refptr<base::SequencedTaskRunner> task_runner);
// ImageDecoder::Delegate implementation.
virtual void OnImageDecoded(const ImageDecoder* decoder,
@@ -68,6 +74,9 @@ class UserImageLoader : public base::RefCountedThreadSafe<UserImageLoader>,
// Specify how the file should be decoded in the utility process.
const ImageDecoder::ImageCodec image_codec_;
+ // Proctect image_info_map_
+ base::Lock lock_;
+
// Holds info structures about all images we're trying to decode.
// Accessed only on FILE thread.
Nikita (slow) 2013/01/22 11:30:54 nit: Comment should be updated now.
bshe 2013/01/22 15:36:26 Done.
ImageInfoMap image_info_map_;

Powered by Google App Engine
This is Rietveld 408576698