Fix login visual hitch on chromebook

chrome/browser/chromeos/login/user_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/user_manager_impl.h"
 
 #include <cstddef>
 #include <set>
 #include <vector>
 
@@ skipping 171 matching lines @@
 
 UserManagerImpl::~UserManagerImpl() {
   // Can't use STLDeleteElements because of the private destructor of User.
   for (UserList::iterator it = users_.begin(); it != users_.end();
        it = users_.erase(it)) {
     if (logged_in_user_ == *it)
       logged_in_user_ = NULL;
     delete *it;
   }
   delete logged_in_user_;
+
+  // Use singleton UserManagerImpl to manage the lifetime of WallpaperManager.
+  delete WallpaperManager::Get();

[Joao da Silva, 2013/01/22 10:04:12]

This is quite strange. Why not make WallpaperManager a Singleton?

(see MediaPlayer::GetInstance() for an example:
chrome/browser/chromeos/media/media_player.cc)

[bshe, 2013/01/22 15:36:26]

Reading comment for singleton here:
http://code.google.com/searchframe#OAMlx_jo-ck/src/base/memory/singleton.h&ex...
I thought it might be good to avoid create singleton as much as possible. And
wallpaper manager can be managed by user manager. But I maybe wrong. I will
convert it to a singleton if you think it doesnt make sense.


On 2013/01/22 10:04:12, Joao da Silva wrote:

 }
 
 void UserManagerImpl::Shutdown() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   cros_settings_->RemoveSettingsObserver(kAccountsPrefDeviceLocalAccounts,
                                          this);
   // Stop the session length limiter.
   session_length_limiter_.reset();
 
   if (device_local_account_policy_service_)
@@ skipping 809 matching lines @@
         device_local_account_policy_service_->GetBrokerForAccount(username);
     if (broker)
       display_name = broker->GetDisplayName();
   }
 
   // Set or clear the display name.
   SaveUserDisplayName(username, UTF8ToUTF16(display_name));
 }
 
 }  // namespace chromeos