Fix login visual hitch on chromebook

chrome/browser/image_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/image_decoder.h"
 
 #include "base/bind.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_utility_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/utility_process_host.h"
 
 using content::BrowserThread;
 using content::UtilityProcessHost;
 
 ImageDecoder::ImageDecoder(Delegate* delegate,
                            const std::string& image_data,
                            ImageCodec image_codec)
     : delegate_(delegate),
       image_data_(image_data.begin(), image_data.end()),
       image_codec_(image_codec),
-      target_thread_id_(BrowserThread::UI) {
+      target_thread_id_(BrowserThread::UI),
+      decode_on_sequence_worker_thread_(false) {
 }
 
 ImageDecoder::~ImageDecoder() {}
 
 void ImageDecoder::Start() {
+  decode_on_sequence_worker_thread_ = false;
   if (!BrowserThread::GetCurrentThreadIdentifier(&target_thread_id_)) {
     NOTREACHED();
     return;
   }
   BrowserThread::PostTask(
      BrowserThread::IO, FROM_HERE,
      base::Bind(&ImageDecoder::DecodeImageInSandbox, this, image_data_));
 }
 
+void ImageDecoder::Start(
+    const base::SequencedWorkerPool::SequenceToken& sequence_token) {

[Joao da Silva, 2013/01/21 08:07:39]

Why not have a single Start() that gets a TaskRunner?

The 1st version is invoked as

base::TaskRunner* task_runner =
    BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE);
decoder->Start(task_runner);

and the 2nd:

base::TaskRunner* task_runner =
    BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(sequence_token);
decoder->Start(task_runner);


CalledOnValidThreadOrWorkerThread() then just becomes:
task_runner_->RunsTasksOnCurrentThread()

[bshe, 2013/01/21 22:53:07]

Good idea!
We only have one Start function now.

On 2013/01/21 08:07:39, Joao da Silva wrote:

+  sequence_token_ = sequence_token;
+  decode_on_sequence_worker_thread_ = true;
+  BrowserThread::PostTask(
+     BrowserThread::IO, FROM_HERE,
+     base::Bind(&ImageDecoder::DecodeImageInSandbox, this, image_data_));

[Joao da Silva, 2013/01/21 08:07:39]

nit: indent (4 spaces)

[bshe, 2013/01/21 22:53:07]

This is an argument of function PostTask, same as BrowserThread::IO. I remember
the arguments should be aligned in this case.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...
 
Or maybe I understood it wrong?

 
On 2013/01/21 08:07:39, Joao da Silva wrote:

+}
+
 bool ImageDecoder::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ImageDecoder, message)
     IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_DecodeImage_Succeeded,
                         OnDecodeImageSucceeded)
     IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_DecodeImage_Failed,
                         OnDecodeImageFailed)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
+bool ImageDecoder::CalledOnValidThreadOrWorkerThread() {
+  if (decode_on_sequence_worker_thread_) {
+    return BrowserThread::GetBlockingPool()->
+        IsRunningSequenceOnCurrentThread(sequence_token_);
+  } else {
+    return BrowserThread::CurrentlyOn(target_thread_id_);
+  }
+}
+
 void ImageDecoder::OnDecodeImageSucceeded(const SkBitmap& decoded_image) {
-  DCHECK(BrowserThread::CurrentlyOn(target_thread_id_));
+  DCHECK(CalledOnValidThreadOrWorkerThread());
   if (delegate_)
     delegate_->OnImageDecoded(this, decoded_image);
 }
 
 void ImageDecoder::OnDecodeImageFailed() {
-  DCHECK(BrowserThread::CurrentlyOn(target_thread_id_));
+  DCHECK(CalledOnValidThreadOrWorkerThread());
   if (delegate_)
     delegate_->OnDecodeImageFailed(this);
 }
 
 void ImageDecoder::DecodeImageInSandbox(
     const std::vector<unsigned char>& image_data) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
-  UtilityProcessHost* utility_process_host = UtilityProcessHost::Create(
-      this, BrowserThread::GetMessageLoopProxyForThread(target_thread_id_));
+  UtilityProcessHost* utility_process_host;
+  if (decode_on_sequence_worker_thread_) {
+    utility_process_host = UtilityProcessHost::Create(
+        this, BrowserThread::GetBlockingPool()->GetSequencedTaskRunner(
+            sequence_token_).get());
+  } else {
+    utility_process_host = UtilityProcessHost::Create(
+        this, BrowserThread::GetMessageLoopProxyForThread(target_thread_id_));
+  }
   utility_process_host->EnableZygote();
   if (image_codec_ == ROBUST_JPEG_CODEC) {
     utility_process_host->Send(
         new ChromeUtilityMsg_RobustJPEGDecodeImage(image_data));
   } else {
     utility_process_host->Send(new ChromeUtilityMsg_DecodeImage(image_data));
   }
 }