Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: chrome/common/extensions/extension.h

Issue 11968032: Move 'theme' parsing out of Extension class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed IncognitoAutofillManagerTest unittest Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/themes/theme_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 5ae4a2ddddccd9dd2b33b690ba212606f3592244..60019d6db4feb98fd6ced36b7fc1d685cec162e1 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -584,12 +584,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Theme-related.
bool is_theme() const;
- base::DictionaryValue* GetThemeImages() const { return theme_images_.get(); }
- base::DictionaryValue* GetThemeColors() const {return theme_colors_.get(); }
- base::DictionaryValue* GetThemeTints() const { return theme_tints_.get(); }
- base::DictionaryValue* GetThemeDisplayProperties() const {
- return theme_display_properties_.get();
- }
// Content Security Policy!
const std::string& content_security_policy() const {
@@ -716,17 +710,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadTextToSpeechVoices(string16* error);
bool LoadIncognitoMode(string16* error);
bool LoadContentSecurityPolicy(string16* error);
-
- bool LoadThemeFeatures(string16* error);
- bool LoadThemeImages(const base::DictionaryValue* theme_value,
- string16* error);
- bool LoadThemeColors(const base::DictionaryValue* theme_value,
- string16* error);
- bool LoadThemeTints(const base::DictionaryValue* theme_value,
- string16* error);
- bool LoadThemeDisplayProperties(const base::DictionaryValue* theme_value,
- string16* error);
-
bool LoadManagedModeFeatures(string16* error);
bool LoadManagedModeSites(
const base::DictionaryValue* content_pack_value,
@@ -894,18 +877,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// The public key used to sign the contents of the crx package.
std::string public_key_;
- // A map of resource id's to relative file paths.
- scoped_ptr<base::DictionaryValue> theme_images_;
-
- // A map of color names to colors.
- scoped_ptr<base::DictionaryValue> theme_colors_;
-
- // A map of color names to colors.
- scoped_ptr<base::DictionaryValue> theme_tints_;
-
- // A map of display properties.
- scoped_ptr<base::DictionaryValue> theme_display_properties_;
-
// A file containing a list of sites for Managed Mode.
base::FilePath content_pack_site_list_;
« no previous file with comments | « chrome/common/extensions/api/themes/theme_handler.cc ('k') | chrome/common/extensions/extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698