Move 'theme' parsing out of Extension class

chrome/browser/themes/theme_service.cc

Index: chrome/browser/themes/theme_service.cc
diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc
index ae0626cba3d12613df5efda6ca6f2d6efb4283de..ed4b593e91834437509adf416a69dfe5e5b55f31 100644
--- a/chrome/browser/themes/theme_service.cc
+++ b/chrome/browser/themes/theme_service.cc
@@ -18,6 +18,9 @@
 #include "chrome/browser/themes/theme_syncable_service.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/api/themes/theme_handler.h"
+#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
@@ -213,6 +216,10 @@ ThemeService::ThemeService()
       number_of_infobars_(0) {
   // Initialize the themeable image map so we can use it on other threads.
   HasThemeableImage(0);
+
+  // Register the ManifestHandler for parsing 'theme' manifest key.
+  extensions::ManifestHandler::Register(extension_manifest_keys::kTheme,
+                                        new extensions::ThemeHandler);

[pkotwicz, 2013/01/30 20:45:28]

This is probably a stupid question. Is there any guarantee that the ThemeService
has been created at the time that we are parsing a theme?

[Joe Thomas, 2013/01/30 21:12:45]

Thanks for the review!

On 2013/01/30 20:45:28, pkotwicz wrote:
Yes, we are making sure that ThemeService gets started at Profile Start-up
(please see the change in theme_service_factory.cc/h). We try to parse the
Manifest file of extension/theme only after profile start-up.

 }
 
 ThemeService::~ThemeService() {