Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11968016: Revert "Removed unused StandardTestSuite.cachedTests field" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index c16dfaf4860daccee92574283165b0a671ea6e42..05d4f75c574be279152fdb41a710cee180f139f4 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -406,6 +406,7 @@ class StandardTestSuite extends TestSuite {
final List<String> statusFilePaths;
TestCaseEvent doTest;
TestExpectations testExpectations;
+ List<TestInformation> cachedTests;
final Path dartDir;
Predicate<String> isTestFilePredicate;
final bool listRecursively;
@@ -501,7 +502,7 @@ class StandardTestSuite extends TestSuite {
// Checked if we have already found and generated the tests for
// this suite.
if (!testCache.containsKey(suiteName)) {
- testCache[suiteName] = [];
+ cachedTests = testCache[suiteName] = [];
return enqueueTests();
} else {
// We rely on enqueueing completing asynchronously.
@@ -624,8 +625,6 @@ class StandardTestSuite extends TestSuite {
String testName;
if (optionsFromFile['isMultitest']) {
- // Multitests do not run on browsers.
- if (TestUtils.isBrowserRuntime(configuration['runtime'])) return;
// Multitests are in [build directory]/generated_tests/... .
// The test name will be '[test filename (no extension)]/[multitest key].
String name = filePath.filenameWithoutExtension;
@@ -802,6 +801,7 @@ class StandardTestSuite extends TestSuite {
isNegativeIfChecked,
hasFatalTypeErrors,
multitestOutcome);
+ cachedTests.add(info);
enqueueTestCaseFromTestInformation(info);
};
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698