Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 11968015: Workaround for pdb size being exceeded for Debug non-shared_library builds (Closed)

Created:
7 years, 11 months ago by scottmg
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Workaround for pdb size being exceeded for Debug non-shared_library builds Adds a stub library project that the main chrome dll depends on that creates a compilation pdb with the same name as the linking pdb that the main dll uses. Compilation pdbs have a larger internal page size (that allows for larger total size) and the internal page size value isn't overwritten during linking. This indirectly allows the pdb size to grow past 1G up to 2G. Requires gyp >= r1560. BUG=170186 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M chrome/chrome_dll.gypi View 2 chunks +16 lines, -0 lines 0 comments Download
A chrome/empty_pdb_workaround.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
scottmg
7 years, 11 months ago (2013-01-16 16:40:48 UTC) #1
Sigurður Ásgeirsson
lgtm - very neat workaround!
7 years, 11 months ago (2013-01-16 18:25:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11968015/1
7 years, 11 months ago (2013-01-16 18:52:13 UTC) #3
commit-bot: I haz the power
Presubmit check for 11968015-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-16 18:52:15 UTC) #4
jam
lgtm
7 years, 11 months ago (2013-01-16 19:11:15 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
7 years, 11 months ago (2013-01-16 19:13:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11968015/1
7 years, 11 months ago (2013-01-16 19:14:09 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-16 23:23:55 UTC) #8
Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

Powered by Google App Engine
This is Rietveld 408576698