Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1196763004: Revert of Revert of Make SharedMemoryHandle a class on Mac. (Closed)

Created:
5 years, 6 months ago by erikchen
Modified:
5 years, 6 months ago
CC:
reveman, chromium-reviews, darin-cc_chromium.org, Daniele Castagna, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@shared_memory_make_class3_base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+768 lines, -34 lines) Patch
M base/base.gypi View 2 chunks +8 lines, -0 lines 0 comments Download
M base/memory/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M base/memory/shared_memory.h View 3 chunks +4 lines, -10 lines 0 comments Download
A base/memory/shared_memory_handle.h View 1 chunk +97 lines, -0 lines 0 comments Download
A base/memory/shared_memory_handle_mac.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A base/memory/shared_memory_mac.cc View 1 chunk +464 lines, -0 lines 0 comments Download
M base/memory/shared_memory_nacl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 6 chunks +3 lines, -14 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M base/memory/shared_memory_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.h View 2 chunks +14 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 2 chunks +56 lines, -0 lines 0 comments Download
M ppapi/proxy/nacl_message_scanner.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
erikchen
Created Revert of Revert of Make SharedMemoryHandle a class on Mac.
5 years, 6 months ago (2015-06-19 22:47:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196763004/1
5 years, 6 months ago (2015-06-19 22:48:59 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 6 months ago (2015-06-19 22:51:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196763004/1
5 years, 6 months ago (2015-06-19 22:55:42 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
5 years, 6 months ago (2015-06-19 22:57:33 UTC) #9
Nico
5 years, 6 months ago (2015-06-19 22:59:26 UTC) #10 
(scottmg already reverted the revert, which is why this doesn't apply)

On Fri, Jun 19, 2015 at 3:57 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Failed to apply the patch.
>
> https://codereview.chromium.org/1196763004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698